Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't try to do a client refresh unless using autoupdate #3365

Closed
Primigenus opened this issue Dec 24, 2014 · 5 comments
Closed

Shouldn't try to do a client refresh unless using autoupdate #3365

Primigenus opened this issue Dec 24, 2014 · 5 comments

Comments

@Primigenus
Copy link
Contributor

@Primigenus Primigenus commented Dec 24, 2014

I'm encountering a very strange issue when working on the Q42 website (http://github.com/q42/q42.nl) -- and nowhere else. Whenever I change a client-side file such as HTML, JS, CSS etc. the terminal will print the following:

=> Client modified -- refreshing
=> Exited from signal: SIGUSR2
=> Meteor server restarted

The server will restart, which takes around a minute, and the CSS live injection or hot reload features don't work. I have to manually refresh the page. This is making it very hard to work quickly. I was hoping the work that went into speeding things up with 1.0.2 would resolve it, but it's still happening and I haven't been able to isolate the issue.

Posting it here in case anyone has some pointers on what to do to isolate it, has encountered something similar, or knows how to debug it.

FYI, I'm running the site on port 80 using sudo meteor --port 80.

@Primigenus Primigenus changed the title `Exited from signal: SIGUSR2` and server restart when client file is changed Exited from signal: SIGUSR2 and server restart when client file is changed Dec 24, 2014
@adnissen
Copy link
Contributor

@adnissen adnissen commented Dec 24, 2014

I'm investigating this now.

@adnissen
Copy link
Contributor

@adnissen adnissen commented Dec 24, 2014

@Primigenus meteor add autoupdate, not sure why it's not always included by default, definitely a bug worth investigating, but I got it to work on your source by doing that.

@adnissen
Copy link
Contributor

@adnissen adnissen commented Dec 24, 2014

Upon further investigation, your project didn't have the meteor-platform package, which includes ```webapp` which includes this. When did you make this project?

@Primigenus
Copy link
Contributor Author

@Primigenus Primigenus commented Dec 24, 2014

@adnissen Thanks! I started this project in December 2012 or so. I've been upgrading it over time, but it's entirely possible that in transitioning I didn't make the upgrade as smoothly as Meteor itself would have. Feels silly that I didn't realise this would be the problem. Awesome!

@Primigenus Primigenus closed this Dec 24, 2014
@glasser
Copy link
Member

@glasser glasser commented Dec 27, 2014

Thanks @adnissen, that's correct. Looks like in Q42/q42.nl@3d0868d they removed standard-app-packages (the old name for meteor-platform) which removed the dependency on autoupdate.

I suppose this is arguably a bug --- perhaps we shouldn't try to do the client-reload unless the app includes autoupdate?

@glasser glasser reopened this Dec 27, 2014
@glasser glasser changed the title Exited from signal: SIGUSR2 and server restart when client file is changed Shouldn't try to do a client refresh unless using autoupdate Dec 27, 2014
@glasser glasser closed this in 6cac051 Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.