Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddp package should be split in two #3452

Closed
glasser opened this issue Jan 9, 2015 · 2 comments
Closed

ddp package should be split in two #3452

glasser opened this issue Jan 9, 2015 · 2 comments

Comments

@glasser
Copy link
Member

@glasser glasser commented Jan 9, 2015

Currently, there's no way to say "I want my project to contain a Node DDP client but no Node DDP server". There are some hacks where the Node part of ddp checks to see if webapp (a weak dependency) exists and uses that to decide whether or not to run a server (but the server code is always loaded); this leads to symptoms like #2168.

We should split the package into ddp-client (which contains a DDP client for both Node and web) and ddp-server (which contains a DDP server for Node). ddp-server should depend strongly on webapp. They will probably both depend on ddp-common for some shared utilities.

ddp should still be a package which should imply ddp-client and ddp-server so that the common cases (like meteor-platform) can just use ddp.

@glasser
Copy link
Member Author

@glasser glasser commented Jan 9, 2015

I don't think this is particularly high priority (it does not affect the common Meteor web app use case) but we would try to review PRs to fix it.

@glasser
Copy link
Member Author

@glasser glasser commented Apr 15, 2015

Fixed; see #4191.

@glasser glasser closed this Apr 15, 2015
mrauhu added a commit to mrauhu/meteor that referenced this issue Aug 8, 2018
mrauhu added a commit to mrauhu/stream-server that referenced this issue Sep 18, 2018
mrauhu added a commit to mrauhu/stream-server that referenced this issue Apr 4, 2020
mrauhu added a commit to mrauhu/meteor that referenced this issue May 8, 2020
mrauhu added a commit to mrauhu/stream-server that referenced this issue May 8, 2020
mrauhu added a commit to mrauhu/meteor that referenced this issue Sep 29, 2020
mrauhu added a commit to mrauhu/stream-server that referenced this issue Sep 29, 2020
mrauhu added a commit to mrauhu/meteor that referenced this issue Feb 11, 2021
mrauhu added a commit to mrauhu/stream-server that referenced this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant