Hooks Accounts.onLogin/onLoginFailure should be available on client

[jakozaur]

Currently Accounts hooks onLogin and onLoginFailure are available only on server.

I am trying to add logic that would move user to certain page on login and it is hard to implement without the hook.

However, it looks logically that this methods should be isomorphic on client. This is one of the core Meteor design philosophy.

Happy to try to implement myself, but would like to get blessing from MDG. Do I sound reasonable? 😄

The only tricky part is that the attempt object would be a bit different on server vs. client (user and connection object). Though I would note it in documentation, I wouldn't worry about it.

[stubailo]

Thanks for the feature request! You might be interested in reading our feature request guidelines.

[stubailo]

FWIW I've also have a need for this in the past and Tracker.autorun( .. Meteor.userId() .. ) doesn't always cut it.

[jakozaur]

Thanks @stubailo so much for the reply!

My previous attempts:
0. Tried onLogin on client without reading docs, didn't work.

1. Call Meteor.login directly, so I can provide callback. Gotcha: Can't use accounts-ui, need to add it to few places.
2. Tracer.autorun. Gotcha: Hard to recognize user login vs. page reload. The naive version doesn't work, since Meteor.user is not loaded immediately. Though it may be masked if your localhost is fast.
3. Use server onLogin hook to change user preferences attribute, than check for it on client. Gotcha: A lot of code for simple thing, prone to bugs. Unnecessary latency...

IMHO, this is common pattern in many apps and can be as simple as:

Accounts.onLogin(function () {
  Router.go("dashboard");
});

Hope to submit some code shortly.

[stubailo]

Yeah I would look at a PR for this.

[AnthonyAstige]

meteor add gwendall:auth-client-callbacks made Accounts.onLogin(...) on the client trigger for me from a quick manual test. I'm not sure on it's internal implementation nor have I tested it in depth.

Reference

• https://atmospherejs.com/gwendall/auth-client-callbacks
• https://github.com/gwendall/meteor-auth-client-callbacks

[jakozaur]

Thanks for pointing @AnthonyAstige that out.

Unfortunately the gwendall:auth-client-callbacks is buggy implementation:
https://github.com/gwendall/meteor-auth-client-callbacks/blob/master/client/lib.js

You get callback on each page reload, not only when you login. It is approach #2 I described few comments above.

[stubailo]

Merged the PR! Right now there is no way of knowing how the login is triggered because we decided not to pass through the arguments, but you can reliably get a callback on login.

[glasser]

I'm not sure I buy the reasoning about not including the method name and arguments, but we can always add it later. But removing the error from the failure hook seems pretty extreme to me.

Overall though this is a great addition to Meteor!

[stubailo]

I think a point could be made that it is good to not have the arguments, because any random client-side library could then add a callback and get the new user's password.

[indesignlatam]

Maybe not returning the whole arguments but at least the type, so on the client we can run code onLogin and code onResume.