New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing `meteor shell` process crashes server #3595

Closed
glasser opened this Issue Jan 30, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@glasser
Member

glasser commented Jan 30, 2015

shell1$ meteor create x; cd x; meteor
shell2$ meteor shell
shell3$ ps auxww | grep 'main.js shell'
glasser         89988   0.0  0.0  2432784    528 s092  S+    7:19PM   0:00.00 grep main.js shell
glasser         89872   0.0  0.2  3068864  32380 s097  S+    7:19PM   0:00.29 /Users/glasser/Projects/Meteor/meteor/dev_bundle/bin/node /Users/glasser/Projects/Meteor/meteor/tools/main.js shell
shell3$ kill 89872

causes the app server (in shell1) to crash:

W20150129-19:18:17.337(-8)? (STDERR) 
W20150129-19:18:17.339(-8)? (STDERR) events.js:72
W20150129-19:18:17.339(-8)? (STDERR)         throw er; // Unhandled 'error' event
W20150129-19:18:17.339(-8)? (STDERR)               ^
W20150129-19:18:17.342(-8)? (STDERR) Error: This socket has been ended by the other party
W20150129-19:18:17.342(-8)? (STDERR)     at Socket.writeAfterFIN [as write] (net.js:275:12)
W20150129-19:18:17.342(-8)? (STDERR)     at REPLServer.<anonymous> (/private/tmp/foo/.meteor/local/build/programs/server/shell.js:123:20)
W20150129-19:18:17.342(-8)? (STDERR)     at REPLServer.emit (events.js:117:20)
W20150129-19:18:17.342(-8)? (STDERR)     at Interface.<anonymous> (repl.js:184:10)
W20150129-19:18:17.342(-8)? (STDERR)     at Interface.emit (events.js:117:20)
W20150129-19:18:17.343(-8)? (STDERR)     at Interface.close (readline.js:272:8)
W20150129-19:18:17.343(-8)? (STDERR)     at Socket.onend (readline.js:95:10)
W20150129-19:18:17.343(-8)? (STDERR)     at Socket.emit (events.js:117:20)
W20150129-19:18:17.343(-8)? (STDERR)     at _stream_readable.js:943:16
W20150129-19:18:17.343(-8)? (STDERR)     at process._tickCallback (node.js:419:13)
=> Exited with code: 8

This doesn't happen if you .exit the shell cleanly.

@benjamn benjamn self-assigned this Feb 3, 2015

@benjamn benjamn closed this in dd4bbc2 Feb 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment