-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing package within project fails with stacktrace. #3676
Comments
+1 |
This is supposed to work. Please provide a full reproduction as described in: https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#reporting-a-bug-in-meteor Without a way to replicate your problem, we can't debug and fix it. |
OK, I see what's going on here. I think this is a crash that happens only when you're running inside an app (as you mentioned), and the publish command doesn't have to rebuild the package because you've run some command that built it (eg just meteor) since the last time you've changed it. (I think if you had tried to make a minimal reproduction as suggested in https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#reporting-a-bug-in-meteor you may have figured that out.) Looking into fixing it now. |
Aha, and it also only happens if you have a mobile platform in your app. |
Christ, we just spent hours on merging all core packages into one repo - we thought it was clever to place them in a Having each package in separate repos makes it impossible to maintain and track issue + cfs with all it's minor packages becomes hard to get an overview (much like on the iron:router) I was getting the cc @aldeed submodule the packages folder? |
@aldeed: maybe I'll just add it to the publish script - move |
@raix, I think next Meteor release is coming soon so maybe we just workaround with a script like you say until this fix is released. |
For a workaround, you can do I'm surprised to hear that people are seeing this issue in apps with no cordova platforms though! |
Ok, thanks @glasser - it's a plain app for now https://github.com/CollectionFS/Meteor-CollectionFS |
Ok, I'm surprised that you can trigger the bug that way, but ok. The isopack directory is just a cache so you should be fine. |
Ah, I think the bug could also happen if you run publish two times in a row without running a non-publish command in the middle. (The bug happens if there is a cached version of the isopack which was built with cordova unibuilds (which are always included in publish commands), which is either because the last command was in a cordova-ified app, or because the last command was a publish command.) |
Ok, makes sense (had one successful publish) |
It also occurs if the previous operation was a publish.
I got an error publishing a package, whose folder was located inside my meteor project. Cloning my repository to a folder on my Desktop allowed me to publish it.
I've noticed that the publish script seems to traverse the parent folder of the package being published. I've no idea why it should do this, but I suspect this to be the cause of the problem (I have a lot of local packages).
Transcript:
The text was updated successfully, but these errors were encountered: