New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.4 #3814

Closed
glasser opened this Issue Feb 25, 2015 · 70 comments

Comments

Projects
None yet
@glasser
Member

glasser commented Feb 25, 2015

This issue tracks the release of Meteor 1.0.4. Have any concerns? Mention them here. Finding that the RCs are working great? Mention that here. We will keep this top-level description updated with known issues.

The current RC is 1.0.4-rc.6. Update to the release candidate with: meteor update --release 1.0.4-rc.6

Read the release notes to learn what's new in this release. Highlights: MongoDB 2.6, a host of mongo-related bugfixes and optimizations, template-level subscriptions, DDP compression, Cordova upgrades, and more! Prerelease docs are at https://docs-104rc.meteor.com/

  • Make sure switching between Mongo 2.6 and Mongo 2.4 doesn't fail in run-mongo #3692
  • New Session.set syntax is undocumented
  • New Session.set syntax is buggy #3849
  • infinite rebuild cycle on --settings dir #3854 (probably a 1.0.2 regression)
  • flaky template-level subs test #3859
  • LocalCollection paused flag performance boost https://rbcommons.com/s/meteor/r/4/
  • evaluate if any packages need a minor/major version boost
  • direct access to npm https://rbcommons.com/s/meteor/r/13/
  • bulk inserts #1255
  • permessage-deflate
  • See if it supports MongoDB 3.0 out of the box.
  • History.md initial pass
  • History.md final draft
  • mailmap update
  • license check
  • self-test --slow
  • full QA
  • all text ready
  • deploy troposphere with rc and profile full sync time [not happening -- reverted websocket change]
  • Review the Template.currentData/Template.parentData change
  • Track down DDP corruption from websocket compression
  • Cordova run-ios fails
  • Cordova issues

RC history:

  • 1.0.4-rc.6:
    • Revert multiple-colon validation from rc 4 (but keep leading/trailing validation, and apply it at create --package time still)
    • Move licenses into a subdirectory.
  • 1.0.4-rc.5:
    • Fixes running Cordova apps on Android emulators.
  • 1.0.4-rc.4:
    • Style cleanup to setPassword change
    • Validate that package names contain at most one colon which cannot be at the beginning or end.
  • 1.0.4-rc.3:
    • Fix an issue with adding broken Cordova plugins (#3914)
    • Validate that package names don't begin with a dash, end with a dot, or contain two dots in a row.
  • 1.0.4-rc.2:
    • Cordova is no longer entirely broken (that's in our QA process, we just hadn't gotten there yet :) )
    • Fix for using blaze package on the server
  • 1.0.4-rc.1:
    • Revert backwards-incompatible Template.currentData/Template.parentData change
    • Revert buggy websocket compression support
    • Accounts.setPassword(u, p, { logout: false }) #3846
    • Fix spacing in a tool message
  • 1.0.4-rc.0: initial release candidate
@stubailo

This comment has been minimized.

Show comment
Hide comment
@stubailo

stubailo Mar 3, 2015

Contributor

The new Session.set syntax is documented, but in a way that is hard to find. I think it is worth the tradeoff because the only other option would be to make the function signature something like Session.set(keyOrObject, [value])

Contributor

stubailo commented Mar 3, 2015

The new Session.set syntax is documented, but in a way that is hard to find. I think it is worth the tradeoff because the only other option would be to make the function signature something like Session.set(keyOrObject, [value])

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 3, 2015

Member

@stubailo Good point — I had only been looking at the api box in session.js and not the markdown file. Sorry!

Member

glasser commented Mar 3, 2015

@stubailo Good point — I had only been looking at the api box in session.js and not the markdown file. Sorry!

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 6, 2015

Member

1.0.4-rc.0 is out! Test it!

Member

glasser commented Mar 6, 2015

1.0.4-rc.0 is out! Test it!

@queso

This comment has been minimized.

Show comment
Hide comment
@queso

queso Mar 6, 2015

Contributor

Can you add a bit about meteor --test being run once now? See #3793.

Contributor

queso commented Mar 6, 2015

Can you add a bit about meteor --test being run once now? See #3793.

@LarsBuur

This comment has been minimized.

Show comment
Hide comment
@LarsBuur

LarsBuur Mar 6, 2015

Could you specify what the Cordova upgrades are about?

LarsBuur commented Mar 6, 2015

Could you specify what the Cordova upgrades are about?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 6, 2015

Member

@queso Thanks, done.

@LarsBuur The release notes cover that it in detail (thanks @Slava!)

Member

glasser commented Mar 6, 2015

@queso Thanks, done.

@LarsBuur The release notes cover that it in detail (thanks @Slava!)

@aminjam

This comment has been minimized.

Show comment
Hide comment
@aminjam

aminjam Mar 7, 2015

With production release of Mongo 3.0, It would be great to have the support in the next release.

aminjam commented Mar 7, 2015

With production release of Mongo 3.0, It would be great to have the support in the next release.

@adrianpacala

This comment has been minimized.

Show comment
Hide comment
@adrianpacala

adrianpacala commented Mar 8, 2015

@aminjam 👍

@mquandalle

This comment has been minimized.

Show comment
Hide comment
@mquandalle

mquandalle Mar 8, 2015

Contributor

I've updated LibreBoard to this latest release candidate. I believe you should emphasize the breaking change concerning the Template.parentData() value in event handlers, because if I wasn't following the development closely I would have wonder why a “patch” release broke my application — I use this feature in 3 different handlers in LibreBoard.

Contributor

mquandalle commented Mar 8, 2015

I've updated LibreBoard to this latest release candidate. I believe you should emphasize the breaking change concerning the Template.parentData() value in event handlers, because if I wasn't following the development closely I would have wonder why a “patch” release broke my application — I use this feature in 3 different handlers in LibreBoard.

@emmanuelbuah

This comment has been minimized.

Show comment
Hide comment
@emmanuelbuah

emmanuelbuah Mar 8, 2015

Can I take it for a spin using meteor run --release 1.0.4-rc.0

emmanuelbuah commented Mar 8, 2015

Can I take it for a spin using meteor run --release 1.0.4-rc.0

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

@aminjam @apacala As I mentioned in the tasklist above was my plan, I've now run the test suite of 1.0.4-rc.0 against a MongoDB 3.0.0 backend. As I expected (because 3.0 actually doesn't have too many user-facing interface changes) it passed right out of the box! I've updated History.md to note this (3cf30fb). We're still going to ship 2.6 with the tool in 1.0.4, since our experience has been that most production users aren't running *.0 versions of software, but hope to update soon, which is now being tracked in #3894.

@mquandalle I'm going to check in with @stubailo about this. My impression was that this was considered a bug fix, since it didn't make sense that Template.currentData() in event handlers didn't match its this data context. But it is backwards-incompatible, so maybe it needs to be more highly advertised (eg with an upgraders notice?)

@emmanuelbuah Yes.

Member

glasser commented Mar 9, 2015

@aminjam @apacala As I mentioned in the tasklist above was my plan, I've now run the test suite of 1.0.4-rc.0 against a MongoDB 3.0.0 backend. As I expected (because 3.0 actually doesn't have too many user-facing interface changes) it passed right out of the box! I've updated History.md to note this (3cf30fb). We're still going to ship 2.6 with the tool in 1.0.4, since our experience has been that most production users aren't running *.0 versions of software, but hope to update soon, which is now being tracked in #3894.

@mquandalle I'm going to check in with @stubailo about this. My impression was that this was considered a bug fix, since it didn't make sense that Template.currentData() in event handlers didn't match its this data context. But it is backwards-incompatible, so maybe it needs to be more highly advertised (eg with an upgraders notice?)

@emmanuelbuah Yes.

@stubailo

This comment has been minimized.

Show comment
Hide comment
@stubailo

stubailo Mar 9, 2015

Contributor

@mquandalle that's a very good point. I wish there were better ways to notify people about small breaking changes, since bumping the major version of all of Blaze seems to be "overkill" for this instance even if it is technically correct. Maybe we need a log of breaking changes since the last major release somewhere? Upgrader could be good, but it might be hard to miss especially since in a collaborative project only one user will see the upgrade message.

Contributor

stubailo commented Mar 9, 2015

@mquandalle that's a very good point. I wish there were better ways to notify people about small breaking changes, since bumping the major version of all of Blaze seems to be "overkill" for this instance even if it is technically correct. Maybe we need a log of breaking changes since the last major release somewhere? Upgrader could be good, but it might be hard to miss especially since in a collaborative project only one user will see the upgrade message.

@TimHeckel

This comment has been minimized.

Show comment
Hide comment
@TimHeckel

TimHeckel Mar 9, 2015

@glasser @stubailo - no issues have come up yet with rc0, and I've ran our app through its paces; I'm really excited for Mongo 3.0, so I'm very happy to hear the initial tests look good!

TimHeckel commented Mar 9, 2015

@glasser @stubailo - no issues have come up yet with rc0, and I've ran our app through its paces; I'm really excited for Mongo 3.0, so I'm very happy to hear the initial tests look good!

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

@mquandalle We're going to not make the backwards-incompatible change in 1.0.4. @stubailo is probably just going to revert that part (or possibly we will come up with a way to do it not incompatibly).

We're going to keep the instance() change which was a bug-fix.

Member

glasser commented Mar 9, 2015

@mquandalle We're going to not make the backwards-incompatible change in 1.0.4. @stubailo is probably just going to revert that part (or possibly we will come up with a way to do it not incompatibly).

We're going to keep the instance() change which was a bug-fix.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

Also reverting websocket compression, which seems to be buggy in at least two ways.

Member

glasser commented Mar 9, 2015

Also reverting websocket compression, which seems to be buggy in at least two ways.

@emgee3

This comment has been minimized.

Show comment
Hide comment
@emgee3

emgee3 Mar 9, 2015

Contributor

Oh, good, I was trying unsuccessfully to create a reproduction on the websocket compression errors I've been having.

Contributor

emgee3 commented Mar 9, 2015

Oh, good, I was trying unsuccessfully to create a reproduction on the websocket compression errors I've been having.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

@emgee3 What symptoms were you seeing?

Member

glasser commented Mar 9, 2015

@emgee3 What symptoms were you seeing?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

and certainly if you manage to make a reproduction it'll help make a reproduction for our upstream library ;)

Member

glasser commented Mar 9, 2015

and certainly if you manage to make a reproduction it'll help make a reproduction for our upstream library ;)

@emgee3

This comment has been minimized.

Show comment
Hide comment
@emgee3

emgee3 Mar 9, 2015

Contributor

Mostly disconnected websockets, with the following error:

WebSocket connection to 'ws://nn.nn.nn.nn:3030/sockjs/488/ychl9h8v/websocket' failed: Could not decode a text frame as UTF-8.

which was caused by corrupted frames. I didn't see what exactly is happening, but the frames contain invalid JSON and mangled.

Interestingly, I don't see this in development, only production (which is self-hosted using meteor build).

I can look into it a bit more if it helps.

Contributor

emgee3 commented Mar 9, 2015

Mostly disconnected websockets, with the following error:

WebSocket connection to 'ws://nn.nn.nn.nn:3030/sockjs/488/ychl9h8v/websocket' failed: Could not decode a text frame as UTF-8.

which was caused by corrupted frames. I didn't see what exactly is happening, but the frames contain invalid JSON and mangled.

Interestingly, I don't see this in development, only production (which is self-hosted using meteor build).

I can look into it a bit more if it helps.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

1.0.4-rc.1 published. It reverts one buggy change and one backwards-incompatible change, and adds a simple PR #3846.

Member

glasser commented Mar 9, 2015

1.0.4-rc.1 published. It reverts one buggy change and one backwards-incompatible change, and adds a simple PR #3846.

@atoi

This comment has been minimized.

Show comment
Hide comment
@atoi

atoi Mar 9, 2015

Blaze in 1.0.4 has an update here which breaks meteor-ssr package. I get 'Template is not defined' error after the update. Should there be Blaze.Template instead of simply Template?

atoi commented Mar 9, 2015

Blaze in 1.0.4 has an update here which breaks meteor-ssr package. I get 'Template is not defined' error after the update. Should there be Blaze.Template instead of simply Template?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 9, 2015

Member

@atoi Is this with 1.0.4-rc.0 or 1.0.4-rc.1?

Member

glasser commented Mar 9, 2015

@atoi Is this with 1.0.4-rc.0 or 1.0.4-rc.1?

@atoi

This comment has been minimized.

Show comment
Hide comment
@atoi

atoi Mar 10, 2015

I tried both. The result is the same.

atoi commented Mar 10, 2015

I tried both. The result is the same.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 10, 2015

Member

Ah, I see. c72f20c should fix this.

Member

glasser commented Mar 10, 2015

Ah, I see. c72f20c should fix this.

@nerdmed

This comment has been minimized.

Show comment
Hide comment
@nerdmed

nerdmed Mar 10, 2015

Hey @glasser @Slava Cordova build for iOS is not working on a fresh meteor project. I have tried the simulator and xCode. Fails to start in both. Meteor 1.0.3.2 is working properly!

I will try to dig deeper, would be great to get this running soon as the new Cordova CLI has some important features!

xCode Log is the following:
2015-03-10 12:12:04.651 CordovaTest[16496:574362] Finished load of: file:///Users/username/Library/Developer/CoreSimulator/Devices/E356E5C2-C84A-4167-84CC-6D87F6F2ED70/data/Containers/Bundle/Application/DA85EDB4-F488-481A-A6DB-FA0DC07448EF/CordovaTest.app/www/index.html
2015-03-10 12:12:04.687 CordovaTest[16496:574362] METEOR CORDOVA DEBUG (meteor_cordova_loader.js) Error reading version file Error: Failed to resolve entry: file:///Users/username/Library/Developer/CoreSimulator/Devices/E356E5C2-C84A-4167-84CC-6D87F6F2ED70/data/Containers/Data/Application/AF08012D-CA0C-4672-86A5-B6997B08AF9B/Library/NoCloud/meteor/version
2015-03-10 12:12:04.687 CordovaTest[16496:574362] METEOR CORDOVA DEBUG (meteor_cordova_loader.js) Couldn't load from the manifest, falling back to the bundled assets.
2015-03-10 12:12:04.688 CordovaTest[16496:574362] Error in Error callbackId: File335718168 : TypeError: undefined is not an object (evaluating 'httpd.startServer')

nerdmed commented Mar 10, 2015

Hey @glasser @Slava Cordova build for iOS is not working on a fresh meteor project. I have tried the simulator and xCode. Fails to start in both. Meteor 1.0.3.2 is working properly!

I will try to dig deeper, would be great to get this running soon as the new Cordova CLI has some important features!

xCode Log is the following:
2015-03-10 12:12:04.651 CordovaTest[16496:574362] Finished load of: file:///Users/username/Library/Developer/CoreSimulator/Devices/E356E5C2-C84A-4167-84CC-6D87F6F2ED70/data/Containers/Bundle/Application/DA85EDB4-F488-481A-A6DB-FA0DC07448EF/CordovaTest.app/www/index.html
2015-03-10 12:12:04.687 CordovaTest[16496:574362] METEOR CORDOVA DEBUG (meteor_cordova_loader.js) Error reading version file Error: Failed to resolve entry: file:///Users/username/Library/Developer/CoreSimulator/Devices/E356E5C2-C84A-4167-84CC-6D87F6F2ED70/data/Containers/Data/Application/AF08012D-CA0C-4672-86A5-B6997B08AF9B/Library/NoCloud/meteor/version
2015-03-10 12:12:04.687 CordovaTest[16496:574362] METEOR CORDOVA DEBUG (meteor_cordova_loader.js) Couldn't load from the manifest, falling back to the bundled assets.
2015-03-10 12:12:04.688 CordovaTest[16496:574362] Error in Error callbackId: File335718168 : TypeError: undefined is not an object (evaluating 'httpd.startServer')
@rclai

This comment has been minimized.

Show comment
Hide comment
@rclai

rclai Mar 10, 2015

The fix for Template.parentData not working properly inside block helpers has been left intact right?

rclai commented Mar 10, 2015

The fix for Template.parentData not working properly inside block helpers has been left intact right?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 10, 2015

Member

@rclai Correct. Feel free to confirm this with rc.1 in case I'm wrong though!

Member

glasser commented Mar 10, 2015

@rclai Correct. Feel free to confirm this with rc.1 in case I'm wrong though!

@tdesc

This comment has been minimized.

Show comment
Hide comment
@tdesc

tdesc Mar 13, 2015

Same here. Cordova not working.

Using (built-in) Android SDK at /Users/----------/.meteor/android_bundle/android-sdk
% Running synchronously:  /Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh [ 'platform', 'list' ]
Error while running for mobile platforms: Error running
/Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.
Error: Error running /Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.

P.S. this workaround from #3481 fix problem
rm -rf .meteor/local/cordova-build
meteor remove-platform ios
meteor add-platform ios

tdesc commented Mar 13, 2015

Same here. Cordova not working.

Using (built-in) Android SDK at /Users/----------/.meteor/android_bundle/android-sdk
% Running synchronously:  /Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh [ 'platform', 'list' ]
Error while running for mobile platforms: Error running
/Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.
Error: Error running /Users/----------/.meteor/packages/meteor-tool/.1.0.42-rc.5.snwbsz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.

P.S. this workaround from #3481 fix problem
rm -rf .meteor/local/cordova-build
meteor remove-platform ios
meteor add-platform ios

@gabrielpoca

This comment has been minimized.

Show comment
Hide comment
@gabrielpoca

gabrielpoca Mar 13, 2015

There is an issue with the cordova-buid-override. Running a cold start application (with no .local folder) with meteor run ios will give the following error.

Error creating Cordova prject: Error running
/Users/gabriel/.meteor/packages/meteor-tool/.1.0.42-rc.5.av4l40++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
App id contains a reserved word, or is not a valid identifier.

Running again you get a different error:

Error while running for mobile platforms: Error running
/Users/gabriel/.meteor/packages/meteor-tool/.1.0.42-rc.5.av4l40++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.

This error occurs because on .meteor/local/cordova-build/config.xml there is com.id4yffpk1heln5x97y8k0, that's not a valid id. Notice here that I have a config.xml file on my cordova-buid-override that should have replaced this one, but it's not happening.

Also, I noticed that if you're running version 1.0.3.2 (or something) and you update to this RC you don't get this issues (as long as you don't remove the .local folder). I know this would be slower, but from my experience with tools like grunt-phonegap I know that it's probably better to always remove the build directory before every run.

gabrielpoca commented Mar 13, 2015

There is an issue with the cordova-buid-override. Running a cold start application (with no .local folder) with meteor run ios will give the following error.

Error creating Cordova prject: Error running
/Users/gabriel/.meteor/packages/meteor-tool/.1.0.42-rc.5.av4l40++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
App id contains a reserved word, or is not a valid identifier.

Running again you get a different error:

Error while running for mobile platforms: Error running
/Users/gabriel/.meteor/packages/meteor-tool/.1.0.42-rc.5.av4l40++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
Current working directory is not a Cordova-based project.

This error occurs because on .meteor/local/cordova-build/config.xml there is com.id4yffpk1heln5x97y8k0, that's not a valid id. Notice here that I have a config.xml file on my cordova-buid-override that should have replaced this one, but it's not happening.

Also, I noticed that if you're running version 1.0.3.2 (or something) and you update to this RC you don't get this issues (as long as you don't remove the .local folder). I know this would be slower, but from my experience with tools like grunt-phonegap I know that it's probably better to always remove the build directory before every run.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 13, 2015

Member

@gabrielpoca Can you show a full reproduction from scratch, with every command in order?

Member

glasser commented Mar 13, 2015

@gabrielpoca Can you show a full reproduction from scratch, with every command in order?

@Slava

This comment has been minimized.

Show comment
Hide comment
@Slava

Slava Mar 13, 2015

Member

@gabrielpoca can you link to a page that describes what "valid id" is? I am confident that at least in Cordova 3.6 the string com.id4yffpk1heln5x97y8k0 was a valid id.

Member

Slava commented Mar 13, 2015

@gabrielpoca can you link to a page that describes what "valid id" is? I am confident that at least in Cordova 3.6 the string com.id4yffpk1heln5x97y8k0 was a valid id.

@gabrielpoca

This comment has been minimized.

Show comment
Hide comment
@gabrielpoca

gabrielpoca Mar 13, 2015

@Slava and you're right. I was just reading the error message and showing what's on the config.xml at the time. Quick search turns into this, but I don't know if the regular expression what they expect. @glasser sure, I'll do that.

gabrielpoca commented Mar 13, 2015

@Slava and you're right. I was just reading the error message and showing what's on the config.xml at the time. Quick search turns into this, but I don't know if the regular expression what they expect. @glasser sure, I'll do that.

@stachrom

This comment has been minimized.

Show comment
Hide comment
@stachrom

stachrom Mar 14, 2015

xmlbuilder and meteor 1.0.4

@glasser I set up the repo : https://github.com/stachrom/meteor_1.0.4

ref: https://forums.meteor.com/t/help-test-release-candidates-for-meteor-1-0-4/896/34

meteor_1.0.4$ meteor add xmlbuilder
=> Errors while adding packages:

While selecting package versions:
error: conflict: constraints on xmlbuilder cannot be satisfied.
Constraints come from:

Regards roman

stachrom commented Mar 14, 2015

xmlbuilder and meteor 1.0.4

@glasser I set up the repo : https://github.com/stachrom/meteor_1.0.4

ref: https://forums.meteor.com/t/help-test-release-candidates-for-meteor-1-0-4/896/34

meteor_1.0.4$ meteor add xmlbuilder
=> Errors while adding packages:

While selecting package versions:
error: conflict: constraints on xmlbuilder cannot be satisfied.
Constraints come from:

Regards roman

@Slava

This comment has been minimized.

Show comment
Hide comment
@Slava

Slava Mar 14, 2015

Member

@stachrom @glasser it could be because the name of the local package collides with the name of the core package that we already have in meteor/meteor: https://github.com/meteor/meteor/tree/devel/packages/xmlbuilder

Member

Slava commented Mar 14, 2015

@stachrom @glasser it could be because the name of the local package collides with the name of the core package that we already have in meteor/meteor: https://github.com/meteor/meteor/tree/devel/packages/xmlbuilder

@stachrom

This comment has been minimized.

Show comment
Hide comment
@stachrom

stachrom Mar 14, 2015

@Slava meteor version 1.0.3.2 with xmlbuilder version 2.4.5 is working fine.
meteor version 1.0.3.2 with xmlbuilder version 2.6.2 (latest) does not work --> conflict: constraints on xmlbuilder cannot be satisfied.

in meteor 1.0.4 neither does work. (xmlbuilder 2.4.5 nor 2.6.2)

stachrom commented Mar 14, 2015

@Slava meteor version 1.0.3.2 with xmlbuilder version 2.4.5 is working fine.
meteor version 1.0.3.2 with xmlbuilder version 2.6.2 (latest) does not work --> conflict: constraints on xmlbuilder cannot be satisfied.

in meteor 1.0.4 neither does work. (xmlbuilder 2.4.5 nor 2.6.2)

@stachrom

This comment has been minimized.

Show comment
Hide comment
@stachrom

stachrom Mar 16, 2015

@Slava @glasser xmlbuilder solved.
I just use the meteor internal package https://github.com/meteor/meteor/tree/devel/packages/xmlbuilder and throw my own xmlbuilder package over board.

Regards roman

stachrom commented Mar 16, 2015

@Slava @glasser xmlbuilder solved.
I just use the meteor internal package https://github.com/meteor/meteor/tree/devel/packages/xmlbuilder and throw my own xmlbuilder package over board.

Regards roman

@tdesc

This comment has been minimized.

Show comment
Hide comment
@tdesc

tdesc Mar 16, 2015

Problem get back. It is not fixed by remove .meteor/local/cordova-build and meteor remove-platform ios
Forced to downgrade to 1.0.3.2, create xcode project and upgrade to 1.0.4-rc.4.
I use cordova 4.3.0 and upgrade cordova platform update ios to cordova-ios@3.8.0

tdesc commented Mar 16, 2015

Problem get back. It is not fixed by remove .meteor/local/cordova-build and meteor remove-platform ios
Forced to downgrade to 1.0.3.2, create xcode project and upgrade to 1.0.4-rc.4.
I use cordova 4.3.0 and upgrade cordova platform update ios to cordova-ios@3.8.0

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 16, 2015

Member

@tdesc Can you show a precise series of commands starting from an empty directory (perhaps including git clone if that's easy) that replicates the issue you're seeing?

Member

glasser commented Mar 16, 2015

@tdesc Can you show a precise series of commands starting from an empty directory (perhaps including git clone if that's easy) that replicates the issue you're seeing?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 16, 2015

Member

1.0.4-rc.5, just released, fixes the ability of Cordova apps to access the server from the Android emulator (meteor run android).

Member

glasser commented Mar 16, 2015

1.0.4-rc.5, just released, fixes the ability of Cordova apps to access the server from the Android emulator (meteor run android).

@rclai

This comment has been minimized.

Show comment
Hide comment
@rclai

rclai Mar 17, 2015

How do you guys plan to revisit the Template.currentData() reversion? I do think that it should reflect what this should be.

rclai commented Mar 17, 2015

How do you guys plan to revisit the Template.currentData() reversion? I do think that it should reflect what this should be.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 17, 2015

Member

@rclai Not decided as part of this release, but most likely we will try to make backwards-incompatible changes like that in either a way that is not backwards compatible (eg new function names/deprecate old ones), opt-in, or backwards-incompatibly but as part of a larger revamp that offers compelling reasons to put the time in to update your app.

Member

glasser commented Mar 17, 2015

@rclai Not decided as part of this release, but most likely we will try to make backwards-incompatible changes like that in either a way that is not backwards compatible (eg new function names/deprecate old ones), opt-in, or backwards-incompatibly but as part of a larger revamp that offers compelling reasons to put the time in to update your app.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 17, 2015

Member

1.0.4-rc.6 partially reverts the no-multiple-colons-in-package-names change, and moves license files to a different place in the built tool (one file per license type).

Member

glasser commented Mar 17, 2015

1.0.4-rc.6 partially reverts the no-multiple-colons-in-package-names change, and moves license files to a different place in the built tool (one file per license type).

@caioreis

This comment has been minimized.

Show comment
Hide comment
@caioreis

caioreis Mar 17, 2015

@glasser, I'm testing a real case here with template subscriptions. In my opinion it's taking too long to unsubscribe after the template is destroyed. It is not a bug, but maybe we can take a look at this?

caioreis commented Mar 17, 2015

@glasser, I'm testing a real case here with template subscriptions. In my opinion it's taking too long to unsubscribe after the template is destroyed. It is not a bug, but maybe we can take a look at this?

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 17, 2015

Member

@caioreis I'm in the process of releasing 1.0.4 now, so this won't affect 1.0.4, but please open a bug (following our usual bug reporting guidelines) and we'll see if it calls for a 1.0.4.1.

Member

glasser commented Mar 17, 2015

@caioreis I'm in the process of releasing 1.0.4 now, so this won't affect 1.0.4, but please open a bug (following our usual bug reporting guidelines) and we'll see if it calls for a 1.0.4.1.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 17, 2015

Member

1.0.4 is released! Thanks for all your help.

Known slight issue: if you're going to http://docs.meteor.com (not https) it may not update you from 1.0.3.2 to 1.0.4 docs (issue with appcache vs force-ssl). @n1mmy is dealing.

Member

glasser commented Mar 17, 2015

1.0.4 is released! Thanks for all your help.

Known slight issue: if you're going to http://docs.meteor.com (not https) it may not update you from 1.0.3.2 to 1.0.4 docs (issue with appcache vs force-ssl). @n1mmy is dealing.

@glasser glasser closed this Mar 17, 2015

@jatsrt

This comment has been minimized.

Show comment
Hide comment
@jatsrt

jatsrt Mar 17, 2015

@gabrielpoca any update on your issue, after an update to 1.0.4 and clearing my .meteor/local I am getting>

I'm fairly sure my app id is legit.

Error creating Cordova prject: Error running /Users/jake/.meteor/packages/meteor-tool/.1.0.42.6fy9sm++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
App id contains a reserved word, or is not a valid identifier.

jatsrt commented Mar 17, 2015

@gabrielpoca any update on your issue, after an update to 1.0.4 and clearing my .meteor/local I am getting>

I'm fairly sure my app id is legit.

Error creating Cordova prject: Error running /Users/jake/.meteor/packages/meteor-tool/.1.0.42.6fy9sm++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/cordova-scripts/cordova.sh
App id contains a reserved word, or is not a valid identifier.

@gabrielpoca

This comment has been minimized.

Show comment
Hide comment
@gabrielpoca

gabrielpoca Mar 17, 2015

@jatsrt I did have the time yet. I should be able to attempt to reproduce the error from scratch. For now you can change back to 1.0.3, remove the .meteor/local/cordova-build, run meteor run ios (or something) and then go to 1.0.4. It should work.

gabrielpoca commented Mar 17, 2015

@jatsrt I did have the time yet. I should be able to attempt to reproduce the error from scratch. For now you can change back to 1.0.3, remove the .meteor/local/cordova-build, run meteor run ios (or something) and then go to 1.0.4. It should work.

@patrickml

This comment has been minimized.

Show comment
Hide comment
@patrickml

patrickml Mar 18, 2015

MUP Deployment is failing after upgrading to version 1.0.4

✘ Invoking deployment process: FAILED

    -----------------------------------STDERR-----------------------------------
    Dnode_root_dir=/root/.node-gyp/0.10.34',
    gyp info spawn args   '-Dmodule_root_dir=/opt/meteor/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'build',
    gyp info spawn args   '-Goutput_dir=.' ]
    gyp info spawn make
    gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
    gyp info ok 
    npm WARN package.json meteor-dev-bundle@0.0.0 No description
    npm WARN package.json meteor-dev-bundle@0.0.0 No repository field.
    npm WARN package.json meteor-dev-bundle@0.0.0 No README data
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (7) Failed to connect to localhost port 80: Connection refused
Latest deployment failed! Reverted back to the previous version.
-----------------------------------STDOUT-----------------------------------
inished
COPY Release/bcrypt_lib.node
make: Leaving directory '/opt/meteor/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt/build'

    > fibers@1.0.5 install /opt/meteor/tmp/bundle/programs/server/node_modules/fibers
    > node ./build.js

    `linux-x64-v8-3.14` exists; testing
    Binary is fine; exiting
    underscore@1.5.2 node_modules/underscore

    eachline@2.3.3 node_modules/eachline
    └── type-of@2.0.1

    semver@4.1.0 node_modules/semver

    chalk@0.5.1 node_modules/chalk
    ├── ansi-styles@1.1.0
    ├── escape-string-regexp@1.0.3
    ├── supports-color@0.2.0
    ├── has-ansi@0.1.0 (ansi-regex@0.2.1)
    └── strip-ansi@0.3.0 (ansi-regex@0.2.1)

    source-map-support@0.2.8 node_modules/source-map-support
    └── source-map@0.1.32 (amdefine@0.1.0)

    fibers@1.0.5 node_modules/fibers
    Waiting for MongoDB to initialize. (5 minutes)
    connected
    meteor stop/waiting
    meteor start/running, process 471
    Waiting for 15 seconds while app is booting up
    Checking is app booted or not?
    meteor stop/waiting
    meteor start/running, process 531
    ----------------------------------------------------------------------------

patrickml commented Mar 18, 2015

MUP Deployment is failing after upgrading to version 1.0.4

✘ Invoking deployment process: FAILED

    -----------------------------------STDERR-----------------------------------
    Dnode_root_dir=/root/.node-gyp/0.10.34',
    gyp info spawn args   '-Dmodule_root_dir=/opt/meteor/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'build',
    gyp info spawn args   '-Goutput_dir=.' ]
    gyp info spawn make
    gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
    gyp info ok 
    npm WARN package.json meteor-dev-bundle@0.0.0 No description
    npm WARN package.json meteor-dev-bundle@0.0.0 No repository field.
    npm WARN package.json meteor-dev-bundle@0.0.0 No README data
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (7) Failed to connect to localhost port 80: Connection refused
Latest deployment failed! Reverted back to the previous version.
-----------------------------------STDOUT-----------------------------------
inished
COPY Release/bcrypt_lib.node
make: Leaving directory '/opt/meteor/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt/build'

    > fibers@1.0.5 install /opt/meteor/tmp/bundle/programs/server/node_modules/fibers
    > node ./build.js

    `linux-x64-v8-3.14` exists; testing
    Binary is fine; exiting
    underscore@1.5.2 node_modules/underscore

    eachline@2.3.3 node_modules/eachline
    └── type-of@2.0.1

    semver@4.1.0 node_modules/semver

    chalk@0.5.1 node_modules/chalk
    ├── ansi-styles@1.1.0
    ├── escape-string-regexp@1.0.3
    ├── supports-color@0.2.0
    ├── has-ansi@0.1.0 (ansi-regex@0.2.1)
    └── strip-ansi@0.3.0 (ansi-regex@0.2.1)

    source-map-support@0.2.8 node_modules/source-map-support
    └── source-map@0.1.32 (amdefine@0.1.0)

    fibers@1.0.5 node_modules/fibers
    Waiting for MongoDB to initialize. (5 minutes)
    connected
    meteor stop/waiting
    meteor start/running, process 471
    Waiting for 15 seconds while app is booting up
    Checking is app booted or not?
    meteor stop/waiting
    meteor start/running, process 531
    ----------------------------------------------------------------------------
@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 18, 2015

Member

@patrickml I think the proper place to file bugs in using MUP deployment is https://github.com/arunoda/meteor-up

If it turns out that there's an underlying Meteor core problem that's breaking MUP deployment, file a new bug that explains what has changed in Meteor to affect MUP.

Member

glasser commented Mar 18, 2015

@patrickml I think the proper place to file bugs in using MUP deployment is https://github.com/arunoda/meteor-up

If it turns out that there's an underlying Meteor core problem that's breaking MUP deployment, file a new bug that explains what has changed in Meteor to affect MUP.

@patrickml

This comment has been minimized.

Show comment
Hide comment
@patrickml

patrickml Mar 18, 2015

@glasser Thank you I have moved my issue over to MUP.

Also meteor update --patch doesnt work after you have upgraded to the newest version and then downgraded.

I.e.

Upgrade to 1.0.4

Downgrade to 1.0.3

try to patch it will failed because it says you already have the latest version

A patch (Meteor 1.0.3.2) for your current release is available!
Update this project now with 'meteor update --patch'.

Patricks-MBP:LF patricklewis$ meteor update --patch
The latest version of Meteor, 1.0.4.1, is already installed on this computer. Run 'meteor update' inside of a particular project directory to update that project to Meteor 1.0.4.1

If anyone else had this issue It has been resolved and can be found here

zodern/meteor-up#321

patrickml commented Mar 18, 2015

@glasser Thank you I have moved my issue over to MUP.

Also meteor update --patch doesnt work after you have upgraded to the newest version and then downgraded.

I.e.

Upgrade to 1.0.4

Downgrade to 1.0.3

try to patch it will failed because it says you already have the latest version

A patch (Meteor 1.0.3.2) for your current release is available!
Update this project now with 'meteor update --patch'.

Patricks-MBP:LF patricklewis$ meteor update --patch
The latest version of Meteor, 1.0.4.1, is already installed on this computer. Run 'meteor update' inside of a particular project directory to update that project to Meteor 1.0.4.1

If anyone else had this issue It has been resolved and can be found here

zodern/meteor-up#321

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 19, 2015

Member

It looks like you're not actually running it inside of an app directory.

Member

glasser commented Mar 19, 2015

It looks like you're not actually running it inside of an app directory.

@jatsrt

This comment has been minimized.

Show comment
Hide comment
@jatsrt

jatsrt Mar 19, 2015

@gabrielpoca Check out #3950 for a thread on this.

jatsrt commented Mar 19, 2015

@gabrielpoca Check out #3950 for a thread on this.

@gwendall

This comment has been minimized.

Show comment
Hide comment
@gwendall

gwendall Mar 20, 2015

Contributor

I also get a "Error creating Cordova prject [...] App id contains a reserved word, or is not a valid identifier." error when running the following on 1.0.4. Works fine on 1.0.3.

meteor create foo
cd foo
meteor add-platform ios

Contributor

gwendall commented Mar 20, 2015

I also get a "Error creating Cordova prject [...] App id contains a reserved word, or is not a valid identifier." error when running the following on 1.0.4. Works fine on 1.0.3.

meteor create foo
cd foo
meteor add-platform ios

@rteslaru

This comment has been minimized.

Show comment
Hide comment
@rteslaru

rteslaru Mar 20, 2015

Running into the same issue as @gwendall, "Error creating Cordova prject [...] App id contains a reserved word, or is not a valid identifier." on 1.0.4.1. Works fine on 1.0.3

Edit: the problem appears to be caused by having a hyphen in the app name. For example:

meteor create my-app
cd my-app
meteor add-platform ios

will raise the App id contains.. error on 1.0.4.1, while

meteor create myapp
cd myapp
meteor add-platform ios

will not raise the error. 1.0.3 works fine with or without the hyphen.

See #3950 for details

rteslaru commented Mar 20, 2015

Running into the same issue as @gwendall, "Error creating Cordova prject [...] App id contains a reserved word, or is not a valid identifier." on 1.0.4.1. Works fine on 1.0.3

Edit: the problem appears to be caused by having a hyphen in the app name. For example:

meteor create my-app
cd my-app
meteor add-platform ios

will raise the App id contains.. error on 1.0.4.1, while

meteor create myapp
cd myapp
meteor add-platform ios

will not raise the error. 1.0.3 works fine with or without the hyphen.

See #3950 for details

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 20, 2015

Member

Great, let's continue to track this in #3950 because 1.0.4 is now out.

Member

glasser commented Mar 20, 2015

Great, let's continue to track this in #3950 because 1.0.4 is now out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment