New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor shell breaks Underscore in 1.0.4.x #4010
Comments
Not underscore-specific -- I just reproduced with EDIT: @artisonian, I can repro with that library without even having to type |
Ah, good catch. I missed this when reviewing 2443d83 which went into 1.0.4. |
Does it also fix the moment issue too? |
Well, I don't know what the moment issue is (no reproduction). |
It's similar. |
I think I have a way to reproduce the issue. meteor create test-moment after it starts stop it, then run Now run Add this route to your route
}, {where: 'server', Create a folder "server" then a file server.js and type Events = {}; W20150401-15:47:01.276(-5)? (STDERR) ReferenceError: Events is not defined Now run moment() and you'll get an error instead of the correct output. Looks like this might have been a problem with body-parser, or it could even be a problem in iron:router, just not sure. Also, if any other projects are using body-parser: "1.12.2" you may never even get this error. I noticed once I upgraded a different project on my local computer to this version I couldn't reproduce the problem even on a my test project. |
This seems pretty complicated. I'm not sure where |
Ok, yea, pretty much the minute I posted my last post I exited the test project and immediately had the same issue again on my real project. I'll do some more work here to try to replicate, it is really hard to pin down. This is the error I get when moment() stops working in the shell, not sure if you can use it to help point me in the right direction or not. TypeError: Property 'moment' of object # is not a function |
@glasser I think I've figured out a better way to reproduce the error. create a new meteor app now remove a smart package while the shell is open To fix the shell you have to stop the meteor app, then start meteor, then start the shell and it works again. Just restarting the shell doesn't work. Also, I noticed that if I tried to restart the shell before meteor was completely started it stayed broken. |
I've found a way to reproduce the issue with the Todos example app. If meteor create --example todos
cd todos
meteor add momentjs:moment
meteor shell The server will be unavailable, so the shell tool will wait for a connection. In another terminal session: meteor Now, if you enter |
@artisonian OK, I'm going to open this as a new issue because it's kind of different from the bug fixed above. #4109 |
Underscore mixins break in
v1.0.4.x
after opening the shell tool. See https://github.com/artisonian/meteor-shell-bug for details and reproduction steps.The text was updated successfully, but these errors were encountered: