New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "duplicate id" warnings in observe sequence #4049

Closed
mitar opened this Issue Mar 28, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@mitar
Collaborator

mitar commented Mar 28, 2015

I have a simple reproduction for a bug in Meteor. It seems observe sequence does not work correctly. It detects duplicate IDs where there are no duplicate IDs. Run the reproduction and observe the web console:

https://github.com/mitar/meteor-issue4049

cc @Slava

@Slava

This comment has been minimized.

Member

Slava commented Mar 28, 2015

This was a fun bug! So it is a common mistake to check something for falsiness and while working with numbers. !!0 === false, this was the bug. A test and a fix coming soon.

Slava added a commit that referenced this issue Mar 28, 2015

@Slava Slava closed this in 111fe5d Mar 28, 2015

@Slava

This comment has been minimized.

Member

Slava commented Mar 28, 2015

On devel.

@mitar

This comment has been minimized.

Collaborator

mitar commented Mar 28, 2015

Thanks.

Slava added a commit that referenced this issue Mar 28, 2015

mitar added a commit to peerlibrary/meteor-blaze-components that referenced this issue Mar 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment