New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: preserve form inputs across hot code reload #4058

Closed
dandv opened this Issue Mar 28, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@dandv
Contributor

dandv commented Mar 28, 2015

Filing here per @glasser in #1969.

Right now, when HCR occurs, form inputs are lost. This can have unwanted consequences especially when a textarea or element with contenteditable=true are re-rendered, and large amounts of user-entered text would be lost.

@Slava

This comment has been minimized.

Show comment
Hide comment
@Slava

Slava Mar 28, 2015

Member

Ideally, we finish local template state (#3561) and the forms templates (like autoforms) will bind there values to there local state. And since the local state can be preserved (if configured so) in templates, this will just work fine.

Member

Slava commented Mar 28, 2015

Ideally, we finish local template state (#3561) and the forms templates (like autoforms) will bind there values to there local state. And since the local state can be preserved (if configured so) in templates, this will just work fine.

@Slava

This comment has been minimized.

Show comment
Hide comment
@Slava

Slava Mar 28, 2015

Member

Another solution for real use cases: postpone the hot code push until the user gets into a state, when there is no state like this to lose and user is inactive for X minutes.

Member

Slava commented Mar 28, 2015

Another solution for real use cases: postpone the hot code push until the user gets into a state, when there is no state like this to lose and user is inactive for X minutes.

@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Mar 28, 2015

Collaborator
Collaborator

mitar commented Mar 28, 2015

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Mar 29, 2015

Member

@Slava And the hooks into hot code reload to do that already do exist (Reload._onMigrate) although not supported/doc'd.

Member

glasser commented Mar 29, 2015

@Slava And the hooks into hot code reload to do that already do exist (Reload._onMigrate) although not supported/doc'd.

@hwillson

This comment has been minimized.

Show comment
Hide comment
@hwillson

hwillson Nov 11, 2016

Member

I've copied this feature request over to the Blaze repo at meteor/blaze#154. This issue can be closed.

Member

hwillson commented Nov 11, 2016

I've copied this feature request over to the Blaze repo at meteor/blaze#154. This issue can be closed.

@abernix

This comment has been minimized.

Show comment
Hide comment
@abernix

abernix Nov 11, 2016

Member

Thanks, @hwillson!

Member

abernix commented Nov 11, 2016

Thanks, @hwillson!

@abernix abernix closed this Nov 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment