Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor should ignore node_modules directory in the root of the project #4452

Closed
mitar opened this issue May 25, 2015 · 4 comments
Closed

Meteor should ignore node_modules directory in the root of the project #4452

mitar opened this issue May 25, 2015 · 4 comments

Comments

@mitar
Copy link
Contributor

@mitar mitar commented May 25, 2015

Many development tools come as a NPM packages (like linting, testing, etc.) and they install dependencies into node_modules directory. It would be very useful if Meteor would not try to compile files inside it and would simply ignore the node_modules directory.

@ekatek
Copy link

@ekatek ekatek commented May 26, 2015

Cool. As long as this is clear that the directory is, really, completely, entirely ignored, and there is documentation for this, it sounds pretty good to me. Pull requests encouraged -- should not be a very complex change. Thanks!

@mitar
Copy link
Contributor Author

@mitar mitar commented May 27, 2015

I was looking around, but didn't find the simplest way to do that. Where is code which ignores tests directory?

mitar added a commit to peerlibrary/meteor that referenced this issue May 27, 2015
@mitar
Copy link
Contributor Author

@mitar mitar commented May 27, 2015

Done: #4457

@glasser glasser closed this in 2e76973 Jun 2, 2015
@glasser
Copy link
Member

@glasser glasser commented Jun 2, 2015

Thanks, merged!

katrotz pushed a commit to katrotz/meteor-jasmine that referenced this issue Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants