New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to authenticate user with github if user's email is private on github #4545

Closed
frenchbread opened this Issue Jun 12, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@frenchbread

frenchbread commented Jun 12, 2015

We are using accounts-github package for authenticating a user on a site. Everything works if user's email is public in github profile settings. But if the email is not publicly visible and even if permission for email requested, this error pops up:

 Exception while invoking method 'login' undefined

Also, there is an existing question about this issue on stackoverflow which might be helpful to review.

@anubhav94

This comment has been minimized.

Contributor

anubhav94 commented Jun 16, 2015

Good point, we should probably be doing something similar to our Google/Facebook packages where we have a default scope of the 'user:emai' and then do a second round trip as seen here: https://developer.github.com/v3/users/emails/. Pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment