New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different subscriptions with similar but different arguments are counted as the same. #455

Closed
tmeasday opened this Issue Nov 5, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@tmeasday
Contributor

tmeasday commented Nov 5, 2012

Probably best expressed through example. See:

https://github.com/tmeasday/meteor-overlapping-subscription-bug

I would expect to see:

[[[[[ ~/Development/Sandbox/meteor-test-project ]]]]]

Running on: http://localhost:3000/
publish called with : { submitted: 1 }
publish called with : { score: 1 }

But instead I see:

[[[[[ ~/Development/Sandbox/meteor-test-project ]]]]]

Running on: http://localhost:3000/
publish called with : { submitted: 1 }

Due to a bug in minimongo, for which I am about to submit a PR.

tmeasday added a commit to tmeasday/meteor that referenced this issue Nov 5, 2012

Fixed a problem with deep object selectors with differing keys in min…
…imongo.

Select from minimongo would match objects who different in deep keys (not values). It seems like the object matching of selector.js was intended to work this way (the name `b_keys` implies that it should be the keys of `b` after all), but was mis-implemented.

Fixes meteor#455 - a subtle bug with almost-overlapping subscriptions

@glasser glasser closed this in c279415 Nov 5, 2012

@glasser

This comment has been minimized.

Member

glasser commented Nov 5, 2012

Thanks for the great reproduction recipe, fix, and unit test Tom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment