Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Better error reporting on the client side. #4890

Closed
trusktr opened this issue Aug 6, 2015 · 13 comments
Closed

[suggestion] Better error reporting on the client side. #4890

trusktr opened this issue Aug 6, 2015 · 13 comments

Comments

@trusktr
Copy link
Contributor

trusktr commented Aug 6, 2015

I see errors like this which are a pain to track:

Exception from Tracker afterFlush function:        debug.js:41
ReferenceError: Cards is not defined               debug.js:41

Errors of this form, from Tracker afterFlush, are always from line "debug.js:41", which is completely not helpful.

In the meantime, I'll keep laboriously hunting and hunting for the source of the error.

@rclai
Copy link

rclai commented Aug 6, 2015

I also suffer from this.

@ghost
Copy link

ghost commented Aug 6, 2015

Reproduce? I get this:

bildschirmfoto vom 2015-08-06 16 17 24

So I see the stack trace.

@trusktr
Copy link
Contributor Author

trusktr commented Aug 7, 2015

@sanjo Interesting. It seems to have a stack trace only sometimes:

screen shot 2015-08-06 at 9 12 55 pm

@rclai
Copy link

rclai commented Aug 7, 2015

It's because @trusktr is using Blaze and @sanjo is using React right?

It seems like React has better stack traces from what I see.

@ghost
Copy link

ghost commented Aug 7, 2015

When I use the starter app (meteor create stack-trace-autorun).

And use my reproduce trigger code:

if (Meteor.isClient) {
  Tracker.autorun(function () {
    if (Session.get('throw')) {
      Cards.foo();
    }
  });
}

And trigger it with Session.set('throw', true), then I get also the stack trace:

Exception from Tracker recompute function:      debug.js:41
ReferenceError: Cards is not defined
    at stack-trace-autorun.js?087898c695bca84a46fc4ec3a4cad37d8878b275:5
    at Tracker.Computation._compute (tracker.js:294)
    at Tracker.Computation._recompute (tracker.js:313)
    at Object.Tracker._runFlush (tracker.js:452)
    at onGlobalMessage (setimmediate.js:102)

I use Google Chrome 44.

So still no reproduce :/

@rclai
Copy link

rclai commented Aug 7, 2015

I think it needs to be in the context of using Blaze. I'll see what I can do.

@stubailo
Copy link
Contributor

Yeah we definitely would need a reproduction to fix this. @trusktr when does it happen for you? Can you post an app where it happens here?

@dearlordylord
Copy link
Contributor

I found that can reproduce it with some older version of Meteor and packages. I'm trying to reproduce same issue with new application with same packages (but never versions), no 'luck' so far.

@dearlordylord
Copy link
Contributor

Issue is meteorhacks:kadira package _debug function overwrite. It removes stack trace, leaving only error message. Related bug is meteorhacks/kadira#193

Reproduced here https://github.com/Firfi/meteor-tracker-kadira-bug-reproduction

@dearlordylord
Copy link
Contributor

It is fixed in Kadira.

@stubailo
Copy link
Contributor

@Firfi thanks for checking that out! Any luck reproducing it without kadira?

@dearlordylord
Copy link
Contributor

No luck reproducing it without.

@stubailo
Copy link
Contributor

OK I see no reproductions after 3 people tried, going to close it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants