New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts package loginExpirationInDays option not working #5121
Comments
Additionally, it looks like the function https://github.com/meteor/meteor/blob/master/packages/accounts-base/accounts_common.js#L170 is called synchronously when the app boots up, unsetting the login token (using the default loginExpirationInDays value of 90 days), before my Accounts.config() call has even been run. Shouldn't this be on a defer to wait for Accounts.config() to be called? |
This looks like a real bug that would be worth fixing. Thanks for the report! |
+1 |
1 similar comment
+1 |
I managed to set the meteor_login_token cookie to end with the browser session, but next start it gets set again from localStorage. If i delete localStorage["Meteor.loginToken"] then the cookie disappears as well and the login is gone. |
It would be really appreciated if this could be fixed! |
+1 This is a big issue for us (Mixmax) |
Haha you're keeping an upvote tally @ top? Count me in 😊 |
any updates? |
BTW will this plugin work? |
Bump on this. This is really bad. |
+1 |
1 similar comment
+1 |
+1 (sorry forgot I had already bumped) |
I know it is a slight variation, but it would be nice to configure the expiry in minutes too! |
temporary bugfix: set services.resume.loginTokens.when in the user object to a future date to achieve that the login doesn't expire |
I agree that there is a bug here. One workaround would be to set loginExpirationInDays to a very large number like |
@mattiLeBlanc Please vote for meteor/meteor-feature-requests#119 |
_5 Upvotes_ According to the docs at http://docs.meteor.com/#/full/accounts_config, the code:
should disable login token expiration. However, I'm not sure this is working locally for me. After looking into the code briefly, it looks like line https://github.com/meteor/meteor/blob/master/packages/accounts-base/accounts_common.js#L170 should include check for
null
explicitly like what is done on the server-side here: https://github.com/meteor/meteor/blob/master/packages/accounts-base/accounts_server.js#L879Is that a bug?
The text was updated successfully, but these errors were encountered: