Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minification error on production #515

Closed
jussiry opened this issue Nov 29, 2012 · 3 comments
Closed

CSS minification error on production #515

jussiry opened this issue Nov 29, 2012 · 3 comments

Comments

@jussiry
Copy link

@jussiry jussiry commented Nov 29, 2012

In production mode CSS minification breaks hsl color definitions by dropping %. E.g. color: hsl(0,0%,75%); becomes color: hsl(0,0,75%);.

@glasser
Copy link
Member

@glasser glasser commented Nov 29, 2012

We use https://npmjs.org/package/clean-css to implement CSS minification. Meteor 0.5.1 upgraded that module from 0.6.0 to 0.8.2, and it looks like 0.8.1 introduced that bug in this commit jakubpawlowicz/clean-css@39763dc. I'll file a bug over there.

@glasser
Copy link
Member

@glasser glasser commented Nov 29, 2012

I filed jakubpawlowicz/clean-css#32.

As a workaround, it looks like 00% doesn't get minimized and works.

@jussiry
Copy link
Author

@jussiry jussiry commented Nov 29, 2012

Ok, thanks!

@glasser glasser closed this in 8ee9959 Nov 30, 2012
glasser added a commit that referenced this issue Nov 30, 2012
This reverts commit 8ee9959.

Need to do this on a branch and build a dev bundle.
glasser added a commit that referenced this issue Nov 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.