Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twitter integration to use API Version 1.1 #527

Closed
timhaines opened this issue Dec 7, 2012 · 3 comments
Closed

Update Twitter integration to use API Version 1.1 #527

timhaines opened this issue Dec 7, 2012 · 3 comments

Comments

@timhaines
Copy link
Contributor

@timhaines timhaines commented Dec 7, 2012

Twitter has released version 1.1 of it's API. 1.0 is being removed early next year.

@gschmidt
Copy link
Member

@gschmidt gschmidt commented Dec 10, 2012

Thanks @timhaines, we will investigate.

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Feb 2, 2013

This is coming up in a month or so.

Is this change as simple as changing one URL in twitter_server.js, or am I missing something? It looks like the oauth urls remain the same.

--- a/packages/accounts-twitter/twitter_server.js
+++ b/packages/accounts-twitter/twitter_server.js
@@ -1,7 +1,7 @@
 (function () {

   Accounts.oauth.registerService('twitter', 1, function(oauthBinding) {
-    var identity = oauthBinding.get('https://api.twitter.com/1/account/verify_credentials.json').data;
+    var identity = oauthBinding.get('https://api.twitter.com/1.1/account/verify_credentials.json').data;

     return {
       serviceData: {
@timhaines
Copy link
Contributor Author

@timhaines timhaines commented Feb 3, 2013

I just took a look at it, and yes, that's all there is to it. Nothing else in meteor specifies a version of the API, nor is there a test covering it. I created a pull request #659 if you're into the one click merges.

@timhaines timhaines closed this Feb 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants