Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe standard-minifiers shouldn't re-minify .min.js files? #5363

Closed
jedwards1211 opened this issue Oct 4, 2015 · 4 comments
Closed

Maybe standard-minifiers shouldn't re-minify .min.js files? #5363

jedwards1211 opened this issue Oct 4, 2015 · 4 comments

Comments

@jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Oct 4, 2015

I'd be happy to make a PR, just want someone to acknowledge that this is a desired feature before I go to the effort

Those of us who are using Webpack are discovering that it takes a long time for Meteor to minify Webpack bundles. Since we can minify more quickly with Webpack's UglifyJS plugin (since it operates on modules individually), it would be nice if we could just output bundles as server.bundle.min.js and Meteor wouldn't run them through UglifyJS again.

@stubailo
Copy link
Contributor

@stubailo stubailo commented Oct 5, 2015

Yeah, I think that could be very reasonable - I can't think of any reason someone would name their file with .min.js if it wasn't minified already. I'll accept the PR if it's a minimal change!

@jedwards1211
Copy link
Contributor Author

@jedwards1211 jedwards1211 commented Oct 6, 2015

Cool! I'll make the PR soon

@jedwards1211
Copy link
Contributor Author

@jedwards1211 jedwards1211 commented Oct 6, 2015

Do you know of any good way I could add the option to disable bypassing .min.js files? (Besides an environment variable), just in case someone needs it? And should I print a message about "assuming yourfile.min.js is already minified" on the off chance it would be a surprise to some dev?

@laosb
Copy link
Collaborator

@laosb laosb commented May 7, 2016

Fixed in #6986 !

@laosb laosb closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants