Spiderable phantomjs doesn't exit cleanly #571
Closed
Labels
Comments
Thanks for the report. Confirmed and replicated. I believe this was caused by e27304c |
Specifically, the |
A fix is under review on the |
Merged to devel in aec2e58. |
tyrchen
pushed a commit
to tyrchen/meteor
that referenced
this issue
Jan 9, 2013
The previous version only killed the wrapper bash script, not the child. We now work around the broken (socketpair) stdin presented to Node's child processes by using a bash heredoc rather than "cat |"; this means we can use exec, which only gives us one process to clean up. While we're at it, simplify code by switching from child_process.spawn to child_process.execFile, which does the work of capturing stdout and setting a timeout for us automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Phantomjs doesn't always exit cleanly. This may have to do with javascript errors? or it might not. Whatever it is it builds up processes until it eats all CPU and the site crashes.
The text was updated successfully, but these errors were encountered: