Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor should not hide errors that have `expected` set #6912

Closed
awwx opened this issue Apr 26, 2016 · 5 comments
Closed

Meteor should not hide errors that have `expected` set #6912

awwx opened this issue Apr 26, 2016 · 5 comments

Comments

@awwx
Copy link
Contributor

@awwx awwx commented Apr 26, 2016

livedata allows tests to set expected on an error so that it isn't displayed:

// tests can set the 'expected' flag on an exception so it won't go to the

However, in production, ordinary errors can have the expected field set. For example, the standard Node assert module sets the expected field on assertion errors. This makes it hard to track down bugs when the error is silently suppressed.

Meteor should use a different field for tests, such as for example _expected_by_test.

@laosb
Copy link
Collaborator

@laosb laosb commented May 9, 2016

Totally should be.

@hwillson
Copy link
Member

@hwillson hwillson commented Jun 12, 2017

To help provide a more clear separation between feature requests and bugs, and to help clean up the feature request backlog, Meteor feature requests are now being managed under the https://github.com/meteor/meteor-feature-requests repository.

This feature request will be closed here, but anyone interested in migrating this feature request to the new repository (to make sure it stays active), can click here to start the feature request migration process. This manual migration process is intended to help identify which of the older feature requests are still considered to be of value to the community. Thanks!

@hwillson hwillson closed this Jun 12, 2017
@awwx
Copy link
Contributor Author

@awwx awwx commented Jun 12, 2017

@hwillson

This feature request will be closed here

This is a bug. (It breaks usage of standard libraries).

Where does it go as a bug?

@hwillson
Copy link
Member

@hwillson hwillson commented Jun 12, 2017

@awwx - it can stay right here. Re-opening (and removing the previously added feature label). Thanks for pointing this out!

@hwillson hwillson reopened this Jun 12, 2017
@hwillson hwillson added Type:Bug and removed Type:Feature labels Jun 12, 2017
@laosb
Copy link
Collaborator

@laosb laosb commented Jun 20, 2017

My fault for having the wrong label. Sorry!

jamesmillerburgess added a commit to jamesmillerburgess/meteor that referenced this issue Jan 4, 2018
Fixes meteor#6912
Switched the property from `expected` to `_expectedByTest`
benjamn added a commit that referenced this issue Jan 10, 2018
* Change error suppressing property in livedata_connection.js
Fixes #6912
Switched the property from `expected` to `_expectedByTest`

* Update History.md and bump package patch versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.