New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.3.1 - Facebook auth type checking error in facebook package 1.2.7 #7255

Closed
workflow opened this Issue Jun 19, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@workflow
Contributor

workflow commented Jun 19, 2016

Trying to login using facebook@1.2.7 (newest version) in Meteor 1.3.3.1 yields the following type check error:

facebook_client.js:40 Uncaught TypeError: Cannot read property 'authType' of null

Please do let me know if you need more info to reproduce.
I'm attaching a one-line PR that fixes this.

@workflow

This comment has been minimized.

Contributor

workflow commented Jun 19, 2016

@zol

This comment has been minimized.

Contributor

zol commented Jun 21, 2016

This looks like a regression caused by 3d3c7ed

@zol zol closed this in #7256 Jun 21, 2016

zol added a commit that referenced this issue Jun 21, 2016

Merge pull request #7256 from workflow/1-3-3-1-facebook-auth-type-che…
…cking-error-in-facebook-package-1-2-7-B-#7255

Adds truthiness check b4 accessing property in facebook package. Fixes #7255

@benjamn benjamn referenced this issue Jun 22, 2016

Merged

Release 1.3.4 #7263

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment