New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteorNpm portable file marker causes npm shrinkwrap to fail on organization npm modules #7296

Closed
egoldblum opened this Issue Jun 24, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@egoldblum

egoldblum commented Jun 24, 2016

$ cat .meteor/release
METEOR@1.3.2.4
$ meteor npm --version
3.9.6
$ ls -la node_modules/\@workpop/
total 8
drwxr-xr-x    4 egoldblum  staff   136 Jun 24 12:45 ./
drwxr-xr-x  272 egoldblum  staff  9248 Jun 24 12:45 ../
-rw-r--r--    1 egoldblum  staff     5 Jun 24 12:11 .meteor-portable
drwxr-xr-x   10 egoldblum  staff   340 Jun 24 12:45 optimistic-middleware/

As you can see, we have a npm module installed that is not in a top level directory under node_modules due to the fact that this belongs to an npm organization.

https://www.npmjs.com/package/@workpop/optimistic-middleware

Before running meteor build, the .meteor-portable does not exist in this directory and meteor npm shrinkwrap works as expected. After running meteor build, this .meteor-portable file causes subsequent shrinkwrapping attempts to fail as this file is not in a npm module directory but is under node_modules

<snip>
npm ERR! Darwin 15.3.0
npm ERR! argv "node" "/Users/egoldblum/.meteor/packages/meteor-tool/.1.3.4.qz3c1w++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm" "shrinkwrap"
npm ERR! node v0.10.45
npm ERR! npm  v3.9.6

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! extraneous: undefined /Users/egoldblum/workpop/Workpop-Web/node_modules/@workpop/.meteor-portable
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/egoldblum/workpop/Workpop-Web/npm-debug.log

.meteor-portable should not be placed if the directory is not a npm module. Usually top level directories in node_modules are, but not always.

// Cache previous results by writing a boolean value to a hidden

@egoldblum

This comment has been minimized.

egoldblum commented Jun 24, 2016

@abhiaiyer91

This comment has been minimized.

abhiaiyer91 commented Jun 29, 2016

What's the progress on this @benjamn ? any timeline for when it'll be fixed? This is super annoying, and slows down both local development and deployments to our development environments

@benjamn benjamn added this to the Release 1.4 milestone Jun 29, 2016

benjamn added a commit that referenced this issue Jun 30, 2016

Only write .meteor-portable files in npm package directories.
Also clean up any existing misplaced .meteor-portable files.

Fixes #7296.

benjamn added a commit that referenced this issue Jul 1, 2016

Only write .meteor-portable files in npm package directories.
Also clean up any existing misplaced .meteor-portable files.

Fixes #7296.
@benjamn

This comment has been minimized.

Member

benjamn commented Jul 1, 2016

I'm planning a Meteor 1.3.4.2 bug fix release, with this fix included. Please run meteor update --release 1.3.4.2-beta.0 if you would like to upgrade your apps immediately.

@benjamn benjamn modified the milestones: Release 1.3.4.2, Release 1.4 Jul 7, 2016

@benjamn benjamn closed this in 9c37dbf Jul 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment