Shell throws an exception when a key is pressed during Meteor's rebuild

[kachkaev]

I've been seeing this for a while and finally decided to report. This is probably applicable to any Meteor 1.3.*

The following exception frequently occurs when Meteor shell is interacted while Meteor is rebuilding itself:

W20160627-11:35:56.831(1)? (STDERR)
W20160627-11:35:56.936(1)? (STDERR) /path/to/project/.meteor/local/build/programs/server/shell-server.js:164
W20160627-11:35:56.936(1)? (STDERR)     if (options.key !== self.key) {
W20160627-11:35:56.936(1)? (STDERR)                ^
W20160627-11:35:56.937(1)? (STDERR) TypeError: Cannot read property 'key' of undefined
W20160627-11:35:56.937(1)? (STDERR)     at /path/to/project/.meteor/local/build/programs/server/shell-server.js:164:16
W20160627-11:35:56.938(1)? (STDERR)     at finish (/path/to/project/.meteor/local/build/programs/server/shell-server.js:130:7)
W20160627-11:35:56.938(1)? (STDERR)     at Socket.onClose (/path/to/project/.meteor/local/build/programs/server/shell-server.js:120:5)
W20160627-11:35:56.938(1)? (STDERR)     at Socket.emit (events.js:117:20)
W20160627-11:35:56.938(1)? (STDERR)     at TCP.close (net.js:466:12)

I'm experiencing this when running both the shell and meteor itself in a single terminal tab, but I guess the exception will still trigger regardless of this.

Steps to reproduce

1. Run meteor run & meteor shell; lsof -P | grep ':3000' | awk '{print $2}' | xargs kill -9 – this will start Meteor in the background and will then open the shell in the foreground. This lets you see the console output without switching between the tabs. When the shell is closed with ^C, meteor server is also killed.
2. Play a bit with the shell.
3. Change one of the project files so that Meteor started to rebuild.
4. While rebuild is taking place, pass any key press to the shell (I often accidentally press up trying to bring up previous shell commands because I think that Meteor has already stopped building, but it has not).
5. See the above error once Meteor build has finished.

Every time the exception occurs I have to restart the server because the shell quits and therefore Meteor's background process gets killed.

Any thoughts?

[abernix]

Thanks for opening this. I've experienced this too and I can confirm that your reproduction steps are accurate.

[benjamn]

This should be fixed if you do meteor update --release 1.4-beta.5.