Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cordova plugin from private registry fails #7336

Closed
jackkav opened this issue Jul 1, 2016 · 1 comment
Closed

Adding Cordova plugin from private registry fails #7336

jackkav opened this issue Jul 1, 2016 · 1 comment

Comments

@jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 1, 2016

meteor add @myscope/cordova-plugin-whatever@1.0.0

meteor add cordova:@myscope/cordova-plugin-whatever@1.0.0

=> Errors while initializing project:         

While reading project metadata:
.../.meteor/cordova-plugins: Cordova plugin must specify version:
@myscope/cordova-plugin-whatever@1.0.0

This issue appears to be due to line 1911 of meteor/tools/cli/commands-packages.js

let [id, version] = target.split('@');

I would expect this to remove the first element in the array and append @ to the first if three exist.

Meteor 1.3.3

Can be reproduced using the above meteor add.

@abernix abernix changed the title Scoped cordova packages from npm install with meteor add Installing Cordova plugin from private registry fails Jul 1, 2016
@abernix abernix changed the title Installing Cordova plugin from private registry fails Adding Cordova plugin from private registry fails Jul 1, 2016
@hwillson
Copy link
Member

@hwillson hwillson commented Mar 24, 2017

Just to re-cap where this issue stands: @jackkav has gratefully started PR #7350 to address this issue, but it was closed due to inactivity. If anyone encounters this issue and would like to help contribute to Meteor, please consider taking a look at (and ideally finishing off) PR #7350. Thanks!

hwillson added a commit to hwillson/meteor that referenced this issue Nov 9, 2017
Fixes an issue preventing the installation of scoped Cordova
packages. For example,
`meteor add cordova:@somescope/some-cordova-plugin@1.0.0`
will now work properly.

Fixes meteor#7336.
@abernix abernix closed this in 27ed9bc Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants