Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual cue to accounts-ui package when user is logging out #769

Closed
EvHaus opened this issue Mar 2, 2013 · 17 comments
Closed

Add visual cue to accounts-ui package when user is logging out #769

EvHaus opened this issue Mar 2, 2013 · 17 comments

Comments

@EvHaus
Copy link

@EvHaus EvHaus commented Mar 2, 2013

See this thread: https://groups.google.com/forum/?fromgroups=#!topic/meteor-talk/Obg62KR1Lq8

There should be a visual cue (ie loading animation) when the Sign Out button is pressed. Because sometimes the sign out process takes a while and it looks like nothing is happening.

@gschmidt
Copy link
Member

@gschmidt gschmidt commented Mar 5, 2013

Thanks @globexdesigns, I definitely agree that it would be nice to have this. The cleanest way would probably just be to enhance accounts-ui to turn on the loading indicator when the logout button is pressed and then use the Meteor.logout callback to clear it.

Tagging pull-requests-encouraged -- anyone want to take a shot at this?

@raix
Copy link
Contributor

@raix raix commented Mar 15, 2013

I'm giving it at go, made a test at http://issue769.meteor.com/
Added two helpers:
{{loggingOut}} and {{loggingInOut}} and a Meteor.loggingOut(); reactive variable.

Added documentation,

(Maybe it would be nice if we had some way of doing: {{#if loggedIn || loggedOut}} or {{#if or loggedIn loggedOut}} ?)

@raix
Copy link
Contributor

@raix raix commented Mar 15, 2013

Side note: Seems that the Accounts is slow in initial loading, maybe slow in general?

@zealoushacker
Copy link
Contributor

@zealoushacker zealoushacker commented Mar 20, 2014

bump. anyone still working on this? considering giving it a go.

@raix
Copy link
Contributor

@raix raix commented Mar 21, 2014

Just make sure you have it cleared with @meteor otherwise you'll be wasting you time.

@zealoushacker
Copy link
Contributor

@zealoushacker zealoushacker commented Mar 21, 2014

I think this makes sense, so long as the meteor package doesn't force a specific spinner/loading image and allows the user to specify that. /cc: @avital. In the thread on google groups, looks like people are rolling their own and/or referencing Meteor.isLoggingIn. I think that I may easily add a Meteor.isLoggingOut flag, that others may tie into to display a specific loader/spinner. Or, shall we have a default?

@raix I don't think this is a waste of time at all, as I've contributed to an accounts-related package in the past, and have gotten only positive feedback.

@raix
Copy link
Contributor

@raix raix commented Mar 21, 2014

Well, just saying the pr i did a year ago got no response, so thats time seems wasted, but nevermind

@josephfinlayson
Copy link

@josephfinlayson josephfinlayson commented Mar 21, 2014

I'd also like to see this feature.

@Morton - try following up. The core team are obviously very busy.

Joseph Finlayson

+44 796 796 5870
+49 162 395 0220

On 21 March 2014 05:57, Morten N.O. Nørgaard Henriksen <
notifications@github.com> wrote:

Well, just saying the pr i did a year ago got no response, so thats time
seems wasted, but nevermind

Reply to this email directly or view it on GitHubhttps://github.com//issues/769#issuecomment-38251073
.

@glasser
Copy link
Member

@glasser glasser commented Apr 19, 2014

We do not use GitHub to track feature requests (other than for Blaze). The core team's current roadmap is at https://roadmap.meteor.com/. Discussions about features that users desire are great topics for the meteor-talk mailing list, where the community can help come up with solutions that don't require core changes.

That said, I'd probably consider a PR here. @raix, did you actually send in a PR, or just link to a demo? (I think this also occurred during a lull where we didn't have the regular GitHub triage process that we do now.)

@glasser glasser closed this Apr 19, 2014
@raix
Copy link
Contributor

@raix raix commented Apr 19, 2014

@glasser can't honestly remember, its over more than a year old, I think the pr #826 got deprecated after half a year or so due to changes in Meteor? The demo was just a small QA

@glasser
Copy link
Member

@glasser glasser commented Jan 30, 2015

We have a new feature request policy so I'll reopen this: https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#feature-requests

@glasser glasser reopened this Jan 30, 2015
@raix
Copy link
Contributor

@raix raix commented Jan 30, 2015

sounds cool @glasser 👍

@stubailo stubailo added the triaged label Oct 22, 2015
@zol zol removed the backlog label May 3, 2016
@hwillson
Copy link
Member

@hwillson hwillson commented Nov 4, 2016

I'll work on getting a PR in for this (since it will address both this issue and #1331).

@abernix
Copy link
Member

@abernix abernix commented Nov 4, 2016

This does seem like it would be a nice little addition!

@hwillson
Copy link
Member

@hwillson hwillson commented Jan 19, 2017

I created PR #8271 to help address this issue (very much based on @raix's original code - thanks!).

@hwillson
Copy link
Member

@hwillson hwillson commented Feb 15, 2017

PR #8271 has been merged, so this functionality will be coming soon! Thanks everyone!

@hwillson hwillson closed this Feb 15, 2017
@abernix
Copy link
Member

@abernix abernix commented Mar 9, 2017

This should be fixed in Meteor 1.4.3.2. You can try the latest 1.4.3.2 beta and help confirm by running:

meteor update --release 1.4.3.2-beta.0

Please report back if you encounter any problems, and thanks for taking reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants