New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual cue to accounts-ui package when user is logging out #769
Comments
Thanks @globexdesigns, I definitely agree that it would be nice to have this. The cleanest way would probably just be to enhance accounts-ui to turn on the loading indicator when the logout button is pressed and then use the Meteor.logout callback to clear it. Tagging |
I'm giving it at go, made a test at http://issue769.meteor.com/ Added documentation, (Maybe it would be nice if we had some way of doing: |
Side note: Seems that the |
bump. anyone still working on this? considering giving it a go. |
Just make sure you have it cleared with @meteor otherwise you'll be wasting you time. |
I think this makes sense, so long as the meteor package doesn't force a specific spinner/loading image and allows the user to specify that. /cc: @avital. In the thread on google groups, looks like people are rolling their own and/or referencing @raix I don't think this is a waste of time at all, as I've contributed to an accounts-related package in the past, and have gotten only positive feedback. |
Well, just saying the pr i did a year ago got no response, so thats time seems wasted, but nevermind |
I'd also like to see this feature. @Morton - try following up. The core team are obviously very busy. Joseph Finlayson +44 796 796 5870 On 21 March 2014 05:57, Morten N.O. Nørgaard Henriksen <
|
We do not use GitHub to track feature requests (other than for Blaze). The core team's current roadmap is at https://roadmap.meteor.com/. Discussions about features that users desire are great topics for the meteor-talk mailing list, where the community can help come up with solutions that don't require core changes. That said, I'd probably consider a PR here. @raix, did you actually send in a PR, or just link to a demo? (I think this also occurred during a lull where we didn't have the regular GitHub triage process that we do now.) |
We have a new feature request policy so I'll reopen this: https://github.com/meteor/meteor/wiki/Contributing-to-Meteor#feature-requests |
sounds cool @glasser |
I'll work on getting a PR in for this (since it will address both this issue and #1331). |
This does seem like it would be a nice little addition! |
PR #8271 has been merged, so this functionality will be coming soon! Thanks everyone! |
This should be fixed in Meteor 1.4.3.2. You can try the latest 1.4.3.2 beta and help confirm by running:
Please report back if you encounter any problems, and thanks for taking reporting this! |
See this thread: https://groups.google.com/forum/?fromgroups=#!topic/meteor-talk/Obg62KR1Lq8
There should be a visual cue (ie loading animation) when the Sign Out button is pressed. Because sometimes the sign out process takes a while and it looks like nothing is happening.
The text was updated successfully, but these errors were encountered: