Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Using arrays defined in vm not recognized by Blaze #each directive #8160
I am creating arrays in a VM. Then I am using these arrays in my Blaze template. Blaze does not recognize that these are valid arrays.
Blaze depends on the Meteor observe_sequence package. And the observe_sequence package uses
There is a writeup here.
@abernix, I may need some help. Here is what I did:
1335 tests of 1390 passed. Most errors are this:
I took a look at C_MINISAT. single line of > 1000 characters. :-). But it looks like it has nothing to do with Blaze.
Next steps? Should I just submit the PR?
OK, I submitted a pull request for this issue. Fairly benign.
I did a quick search of all instances of
Mind if I take a look at this across Meteor? Should I create separate bug?
Thanks for submitting that, @brucejo75. The test failures are likely because running the test command you're using would be running all tests across all packages, some of which are known to fail (and excluded explicitly). If you're ever developing on a particular package within Meteor you can run just that subset of the tests by passing the package name to
If you can reproduce a problem with other instances, I think PRs for those are appropriate there as well but as @mitar says, only if you notice a problem. Feel free to open separate issues if you feel it's worth separate discussions but I think a sufficient explanation in the PR body referencing this issue might be okay if there are a lot of cases.