Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps.flush hides Error.message #822

Closed
timhaines opened this issue Mar 14, 2013 · 2 comments
Closed

Deps.flush hides Error.message #822

timhaines opened this issue Mar 14, 2013 · 2 comments

Comments

@timhaines
Copy link
Contributor

@timhaines timhaines commented Mar 14, 2013

Deps.flush has a try/catch in it with a catch this:

catch (e) {
            _debugFunc()("Exception from Deps afterFlush function:",
                         e.stack);
}

This was causing the following exception to be logged in my console:

Exception from Meteor.flush: undefined

I've just spent a while trying to figure out what's going on. Turns out e.message had just the info I needed, but that's not logged to the console here. Can it be please?

https://github.com/meteor/meteor/blob/master/packages/deps/deps.js#L231

@raix
Copy link
Contributor

@raix raix commented Mar 17, 2013

Dont Think all browsers support .stack, voting for: (e.stack II e.message) in gereral. Theres two lines in Deps.js

cmather added a commit that referenced this issue Mar 21, 2013
Prints e.message if e.stack undefined.
@cmather cmather closed this Mar 21, 2013
@cmather
Copy link
Contributor

@cmather cmather commented Mar 21, 2013

@timhaines, Thanks for filing. @raix thanks for suggestion!

sdarnell referenced this issue in sdarnell/meteor-win Apr 7, 2013
Prints e.message if e.stack undefined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.