New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.4.2.5] npm "Cannot find module" errors. #8325
Comments
Hi @arthurtea - you repro isn't quite valid though. You're missing a {
"main": "index.js",
"version": "1.0.0"
} in {
"name": "app",
"private": true,
"scripts": {
"start": "meteor run"
},
"dependencies": {
"meteor-node-stubs": "~0.2.0",
"babel-runtime": "6.18.0",
"mod": "1.0.0"
}
} your app will start properly, and you won't get any errors. |
I got the same error with an own npm (let's call it "foo") module after upgrading to 1.4.2.5
i removed node_modules and reinstalled with meteor npm install, but it did not help, so i needed to downgrade to 1.4.2.3 again |
@macrozone - are you able to put together a small reproduction showing this issue? The original reproduction provided in this issue would have thrown that exact same error with 1.4.2.3 (because of the items I mentioned in #8325 (comment)). Thanks! |
@hwillson Thanks. The problem is resolved after I added the dependencies to package.json . A small inconvenience is that I use a lot of |
Cannot find module 'websocket'. |
Also when "@org/privatepackage" syntax is used in an import, even though the package is installed and saved via meteor npm.. which is also reported in #8278, this is METEOR@1.4.2.5 specific. Downgrading to 1.4.2.3 all is ok. |
That's the issue i have. We use a namespaced package.
should i open a different issue for that?
Aaron Judd <notifications@github.com> schrieb am Mi., 8. Feb. 2017, 02:15:
… Also when ***@***.***/privatepackage" syntax is used in an import, even though
the package is installed.. which is also reported in #8278
<#8278>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8325 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB4YgWaExzxnmWMmfdEaNhWO2S9SFOsOks5raRccgaJpZM4L5Yjj>
.
|
I met the same problem with braintree package.
Seem like it cannot find the dependencies inside the braintree package. Please give me some advises. Thanks. |
If you're experiencing this problem, please try to reproduce using Meteor 1.4.2.3 and report back if you still have the same issue. It sounds like a couple different issues might be mentioned in this thread. @gtokenThinhnguyen Your issue is definitely a problem related to Meteor 1.4.2.5. A commit intended to fix some deployments (2613582) is causing nested NPM dependencies to get incorrectly stripped. That being said, we've unrecommended Meteor 1.4.2.5 which leaves Meteor 1.4.2.3 as the most-recommended version. Stay tuned for updates! |
The @google/maps npm package seems to reproduce the error on 1.4.2.5.
yields:
Works fine. |
We're going to do a 1.4.2.6 follow-up release to fix this. |
@benlavalley Thanks for the clear and easy reproduction. I can confirm that |
This should be fixed if you run |
Still having an issue with
|
@jvallarvisp Hard to tell from the error if that's really the same problem. If you can provide a reproduction, then we can help you track down the problem. |
I have to update npm module |
I'm having a similar issue to @benlavalley's in Meteor 1.5.x.x - but specifically in the shell without first requiring the module in 1.5 Works Fine
1.5.2.2 Does Not
1.5.2.2 Works With Require In File
Am I supposed to |
I'm having this issue now with 1.10.2. The first missing module was |
hi @llnathanll please open a new issue. We are not aware of any bug that could be causing this then probably is something in your code but open a new issue with details so we can check. |
How to produce the error:
mod
hasrequire('./localFile')
.mod
.A script to produce the error:
If I use a symlink instead of
cp -a ../mod
, requiring './b' doesn't throw; but ifmod
requires a modulemod2
andmod2
requires its own local file, meteor will throw.OS: Linux Mint 18
The text was updated successfully, but these errors were encountered: