New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide facebook-config-ui notice #8366

Closed
jancurn opened this Issue Feb 14, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@jancurn

jancurn commented Feb 14, 2017

After upgrading accounts-facebook@1.0.11 to accounts-facebook@1.1.0 I started receiving the following warning in the stderr:

W20170214-10:53:13.628(1)? (STDERR) Note: You're using accounts-ui and accounts-facebook,
W20170214-10:53:13.684(1)? (STDERR) but didn't install the configuration UI for the Facebook
W20170214-10:53:13.684(1)? (STDERR) OAuth. You can install it with:
W20170214-10:53:13.684(1)? (STDERR) 
W20170214-10:53:13.685(1)? (STDERR)     meteor add facebook-config-ui
W20170214-10:53:13.685(1)? (STDERR) 

It originates from file meteor/packages/accounts-facebook/notice.js. I realize this hint might be useful to developers who are just setting up a new Meteor app, but it's annoying for developers who already have their apps configured and running in production. It would be great if there was an option to suppress the notice.

BTW this issue relates also to github-config-ui, google-config-ui and twitter-config-ui packages.

@abernix

This comment has been minimized.

Member

abernix commented Feb 14, 2017

You're absolutely right. As an alternative to the configuration interface provided by the <service>-config-ui packages, are you using service-configuration (as a Meteor package)? Perhaps we should not show the above message if service-configuration installed?

@jancurn

This comment has been minimized.

jancurn commented Feb 17, 2017

Yeah, we're using service-configuration, I think the solution you suggested would work well.

@hwillson

This comment has been minimized.

Member

hwillson commented Feb 17, 2017

Thanks @jancurn - I'll get a PR ready to address this shortly.

@hwillson hwillson self-assigned this Feb 17, 2017

@jancurn

This comment has been minimized.

jancurn commented Feb 17, 2017

You guys rock, thanks a million!

@hwillson

This comment has been minimized.

Member

hwillson commented Mar 1, 2017

PR #8429 has been merged, so this will be coming soon. Closing for now - thanks!

@hwillson hwillson closed this Mar 1, 2017

@abernix abernix added this to the Release 1.4.3.x milestone Mar 9, 2017

@abernix

This comment has been minimized.

Member

abernix commented Mar 9, 2017

This should be fixed in Meteor 1.4.3.2. You can try the latest 1.4.3.2 beta and help confirm by running:

meteor update --release 1.4.3.2-beta.0

Please report back if you encounter any problems, and thanks for reporting this originally! (And thanks @hwillson for the fix!)

@abernix abernix modified the milestones: Release 1.4.3.x, Release 1.4.3.2 Mar 9, 2017

@jancurn

This comment has been minimized.

jancurn commented Mar 10, 2017

It works, the log messages are gone. Thanks again guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment