Skip to content

/ meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish this.changed API too strict #850

Closed
mitar opened this issue Mar 20, 2013 · 2 comments
Closed

Publish this.changed API too strict #850

mitar opened this issue Mar 20, 2013 · 2 comments

Comments

@mitar
Copy link
Collaborator

@mitar mitar commented Mar 20, 2013

I think that Meteor.publish this.changed API is too strict. I am getting "Could not find field to clear" error when I am trying to set a field to undefined, just to be sure, because I have multiple program paths. Wouldn't it be better that it would simply ignore unsetting the value if it is not set in the first place? What is the use rationale why it is necessary to throw an error in this case?
cmather added a commit that referenced this issue Mar 21, 2013
@cmather
Fixes #850. Publish this.changed unset a field that doesn't exist.
4ff1764 
This used to throw an error "Could not find field to clear". Now it
doesn't.
@cmather cmather closed this Mar 21, 2013
@mitar
Copy link
Collaborator Author

@mitar mitar commented Mar 21, 2013

Great!
@alanning
Copy link
Contributor

@alanning alanning commented Mar 28, 2013

Thanks for the patch, Chris. Just ran across this issue myself and this resolved it.
sdarnell referenced this issue in sdarnell/meteor-win Apr 7, 2013
@cmather @sdarnell
Fixes #850. Publish this.changed unset a field that doesn't exist.
84ce576 
This used to throw an error "Could not find field to clear". Now it
doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@cmather @mitar @alanning