New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cordova] Update to new version 7.0 release with Meteor 1.5.x release #8686

Closed
skirunman opened this Issue May 10, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@skirunman
Contributor

skirunman commented May 10, 2017

The Cordova project just announced a major new release to Cordova v7.0 which includes Cordova Android v6.2.2 and Cordova iOS v4.4.0. There are also updates to most of the Cordova plugins.

As of Meteor 1.4.4.2 we are using Cordova 6.4.0 with Cordova Android v6.1.1 and Cordova iOS v4.4.0. It would also be great to to update to Cordova Crosswalk 2.3.0, which should be the last official release of Crosswalk.

Ideally we could get issue #8195 implemented, but in the meantime we can follow the work done in #8239 to at least support this update.

These changes should be more palatable in a major release like the 1.5 release . Also, this new feature should help with managing the issue of breaking hot code push #8581 for those that don't want to re-submit their apps.

@benjamn

This comment has been minimized.

Member

benjamn commented May 16, 2017

I would be all for putting this in Meteor 1.5 if there was already a working PR, and 1.5 was still in beta. Let's definitely do this for Meteor 1.5.1.

@skirunman

This comment has been minimized.

Contributor

skirunman commented May 16, 2017

Looks like there is a Cordova 7.0.1 release.

Also, with Cordova 7 it looks like there are likely some breaking changes, including moving in the direction of using npm and package.json to specify dependencies instead of config.xml, that it probably makes sense to "bite the bullet" and implement issue 8195 to make it possible to install Cordova directly from NPM.

Unfortunately I don't have time to work on a PR, but I'd be willing to contribute to a bounty for someone to do this work. For non-react-native mobile development I think this unbundling of Cordova is really a critical feature going forward.

@hwillson hwillson removed the review label May 17, 2017

@skirunman

This comment has been minimized.

Contributor

skirunman commented May 31, 2017

Also, doing this update including supporting Cordova Android 6.2.1+ should fix issue #8464 and probably #8424 and #8408

@hwillson

This comment has been minimized.

Member

hwillson commented Jun 6, 2017

To help provide a more clear separation between feature requests and bugs, and to help clean up the feature request backlog, Meteor feature requests are now being managed under the https://github.com/meteor/meteor-feature-requests repository.

This feature request will be closed here, but anyone interested in migrating this feature request to the new repository (to make sure it stays active), can click here to start the feature request migration process. This manual migration process is intended to help identify which of the older feature requests are still considered to be of value to the community. Thanks!

@hwillson hwillson closed this Jun 6, 2017

@hwillson hwillson reopened this Jun 6, 2017

@hwillson

This comment has been minimized.

Member

hwillson commented Jun 6, 2017

Sorry, re-opening (this is slotted in the 1.5.1 milestone).

@kkukielka

This comment has been minimized.

kkukielka commented Jun 14, 2017

Will it be merged in 1.5.1 or later? I'm still using old, sad METEOR@1.4.3.2 for my mobile app :(

@skirunman

This comment has been minimized.

Contributor

skirunman commented Jun 14, 2017

I don't think anyone has submitted a PR to fix this issue including meteor/meteor-feature-requests#112 which was opened to replace the closed #8195

@kkukielka

This comment has been minimized.

kkukielka commented Jun 16, 2017

@skirunman oh. I don't know why I saw 7 commits instead of 7 comments. Sorry for useless question :)

@skirunman

This comment has been minimized.

Contributor

skirunman commented Jul 20, 2017

PR #8919 has been merged into Meteor 1.5.2-beta.3 release for Cordova 7.0.1 update so please test.

@abernix

This comment has been minimized.

Member

abernix commented Sep 7, 2017

This has been released in Meteor 1.5.2. Thanks so much, @skirunman!

@abernix abernix closed this Sep 7, 2017

@abernix abernix added this to the Release 1.5.2 milestone Sep 7, 2017

@abernix abernix removed this from the Release 1.5.1 milestone Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment