You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Thanks for reporting this @edi9999. I wouldn't necessarily call this a bug; Npm.depends was designed to meet NPM's original dependency requirements, which at the time didn't include supporting any type of http/https URL. Adjusting Npm.depends to line up with https://docs.npmjs.com/files/package.json#urls-as-dependencies is more of a feature request. That being said, since you're already submitted a PR to address this, we'll leave this issue open here (instead of migrating it to http://github.com/meteor/meteor-feature-requests). Thanks for your work on this!
@bmanturner That works, but the submitted PR (#9237) is interested in opening things up further. The current implementation supports tarball links in the format you mentioned, with a commit hash. The PR opens this up to any http/https based link.
meteor version : 1.5.2.2
Create a package with following package.js file :
Actual behavior :
The code is failing with :
Expected behavior.
It should install the module
npm install https://github.com/caolan/async/archive/v2.3.0.tar.gz
works as expected.I have found the source of the problem and will do a small Merge request.
The text was updated successfully, but these errors were encountered: