Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.7.0.1] depends on a version of npm and pacote which has an ugly bug #9940

Closed
csillag opened this issue Jun 5, 2018 · 16 comments
Closed

[1.7.0.1] depends on a version of npm and pacote which has an ugly bug #9940

csillag opened this issue Jun 5, 2018 · 16 comments
Assignees

Comments

@csillag
Copy link

@csillag csillag commented Jun 5, 2018

Meteor currently depends on a version of NPM and pacote which has an ugly error, which for me, causes every single docker build to fail.

According to the History,

The npm package has been upgraded to version 5.10.0, and our fork of its pacote dependency has been rebased against version 7.6.1.

The issue in pacote: zkat/pacote#142
The issue in pnm: npm/npm#19989

The fixes has been released in pacote 8.1.6.

The Meteor for for should be updated with the fixes, too.

Thank you.

benjamn added a commit that referenced this issue Jun 5, 2018
Fixes #9940.
@benjamn benjamn added this to the Release 1.7.1 milestone Jun 5, 2018
@benjamn
Copy link
Member

@benjamn benjamn commented Jun 5, 2018

We've now published the first beta of Meteor 1.7.1, so you should be able to update like so

meteor update --release 1.7.1-beta.0

Unfortunately, the npm version is somewhat tied to the meteor-tool version, so a new Meteor release will be necessary here (not just a package update).

@benjamn benjamn self-assigned this Jun 5, 2018
@csillag
Copy link
Author

@csillag csillag commented Jun 5, 2018

OK, I can confirm that the problem doesn't occur with 1.7.1-beta.0.

Thanks for the quick fix!

@impactmass
Copy link

@impactmass impactmass commented Jun 8, 2018

We're also seeing this issue in builds of Reaction using Meteor v1.7.0.1 with it's npm@5.10.0. Running with npm@5.6.0 give passing builds.

I've tried running meteor update --release 1.7.1-beta.0 and still got the npm ERR! write after end errors.

Looks like the solution will be around @benjamn 's statement:
Unfortunately, the npm version is somewhat tied to the meteor-tool version, so a new Meteor release will be necessary here (not just a package update).

@janjilek
Copy link

@janjilek janjilek commented Jul 4, 2018

Any updates? 1.7.0.3 and 1.7.1-beta.0 is still crashing with "ERR! write after end" in docker build. Is there some workaround? I am not able to release to production anymore and it's really frustrating...

@csillag
Copy link
Author

@csillag csillag commented Jul 10, 2018

For me, the 1.7.1. beta line worked fine, last time I checked.

@csillag
Copy link
Author

@csillag csillag commented Jul 10, 2018

Just checked, and as of now, both 1.7.0.3 and 1.7.1-beta.15 works correctly for me.

@janjilek
Copy link

@janjilek janjilek commented Jul 13, 2018

I checked it again and it fails every time with latest 1.7.1-beta and 1.7.0.3. When 1.7.1 will be released, please? I am thinking to migrate away from meteor, because there is some kind of issue with every meteor update...

@csillag
Copy link
Author

@csillag csillag commented Jul 17, 2018

Just checked, and as of now, both 1.7.0.3 and 1.7.1-beta.15 works correctly for me.

Well actually, the problem still occurs with 1.7.0.3, just not every single time.

@csillag
Copy link
Author

@csillag csillag commented Jul 17, 2018

Fortunately, 1.7.1-beta.18 seems to work correctly for me.

@benjamn
Copy link
Member

@benjamn benjamn commented Jul 18, 2018

We'll close this when Meteor 1.7.1 gets to Release Candidate status (soon).

@morexlt
Copy link

@morexlt morexlt commented Jul 19, 2018

Same as @csillag 1.7.1-beta.18 work fine!

@janjilek
Copy link

@janjilek janjilek commented Aug 2, 2018

Hello, I now, that I am quite annoying, but do you have any ETA for the release? I am able to build it with ~1% probability. And every build takes 20-30 minutes... So basically I have one machine trying to build new version 24/7.

@morexlt
Copy link

@morexlt morexlt commented Aug 2, 2018

Hello, I now, that I am quite annoying, but do you have any ETA for the release? I am able to build it with ~1% probability. And every build takes 20-30 minutes... So basically I have one machine trying to build new version 24/7.

Ohh @janjilek that's awful. Check https://github.com/qualialabs/one only for dev. Or install 1.7.1-beta.18 (only in linux not OSX) hope it helps

@janjilek
Copy link

@janjilek janjilek commented Aug 3, 2018

Thank you, but I need production ready image, I cannot afford to release unstable/beta version. Development is not a problem, I run it without problems on my dev machine.

@benjamn benjamn modified the milestones: Release 1.7.1, Release 1.7.0.4 Aug 6, 2018
@benjamn
Copy link
Member

@benjamn benjamn commented Aug 6, 2018

Update: we're going to fix this problem in Meteor 1.7.0.4, which should be released today or tomorrow. Stay tuned!

@janjilek
Copy link

@janjilek janjilek commented Aug 6, 2018

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants