New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default `test` folder on 1.7.0.1 `meteor create` in legacy mode breaks the app #9961

Closed
robfallows opened this Issue Jun 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@robfallows
Contributor

robfallows commented Jun 7, 2018

Reproduction

meteor create test-app

Edit package.json to remove the meteor stanza. This restores legacy eager loading.

meteor npm i
meteor run

=> Started proxy.
=> Started MongoDB.
W20180607-11:11:12.808(1)? (STDERR) C:\Users\rfallows\AppData\Local\.meteor\packages\meteor-tool\1.7.0_1\mt-os.windows.x86_64\dev_bundle\server-lib\node_modules\fibers\future.js:280
W20180607-11:11:12.877(1)? (STDERR)                                             throw(ex);
W20180607-11:11:12.878(1)? (STDERR)                                             ^
W20180607-11:11:12.878(1)? (STDERR)
W20180607-11:11:12.879(1)? (STDERR) ReferenceError: describe is not defined
W20180607-11:11:12.879(1)? (STDERR)     at main.js (test/main.js:3:1)
W20180607-11:11:12.880(1)? (STDERR)     at fileEvaluate (packages\modules-runtime.js:339:7)
W20180607-11:11:12.880(1)? (STDERR)     at require (packages\modules-runtime.js:238:16)
W20180607-11:11:12.880(1)? (STDERR)     at C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\app\app.js:91:1
W20180607-11:11:12.881(1)? (STDERR)     at C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\boot.js:411:36
W20180607-11:11:12.881(1)? (STDERR)     at Array.forEach (<anonymous>)
W20180607-11:11:12.881(1)? (STDERR)     at C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\boot.js:220:19
W20180607-11:11:12.882(1)? (STDERR)     at C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\boot.js:471:5
W20180607-11:11:12.882(1)? (STDERR)     at Function.run (C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\profile.js:510:12)
W20180607-11:11:12.882(1)? (STDERR)     at C:\Users\rfallows\meteor\mytest\.meteor\local\build\programs\server\boot.js:470:11
=> Exited with code: 1

Kill the process and rename folder test/ to tests/ and re-run:

mv test tests
meteor

=> Started proxy.
=> Started MongoDB.
=> Started your app.

=> App running at: http://localhost:3000/
   Type Control-C twice to stop.
@benjamn

This comment has been minimized.

Member

benjamn commented Jun 7, 2018

The layout of the default new app now depends on the use of meteor.mainModule and meteor.testModule. If you decide to remove that configuration, you'll have to reorganize the directories. This is working as intended.

@benjamn

This comment has been minimized.

Member

benjamn commented Jun 8, 2018

That said, if anyone has time to submit a PR to rename the test/ directory to tests/ for the default app and the --minimal app, I would happily merge it. Just be sure to update the meteor.testModule section in package.json accordingly.

robfallows added a commit to robfallows/meteor that referenced this issue Jun 11, 2018

@benjamn benjamn closed this in a52b462 Jun 11, 2018

@benjamn benjamn added this to the Release 1.7.1 milestone Jun 11, 2018

benjamn added a commit that referenced this issue Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment