New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split bundles into separate sunbursts in bundle-visualizer #10025

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
2 participants
@jamesmillerburgess
Contributor

jamesmillerburgess commented Jun 24, 2018

Posting as WIP because I would like to get some feedback on the design. Please let me know what you think could be better!

The pills along the top are clickable and switch the sunburst between the two bundles, like so:

screen shot 2018-06-24 at 8 12 53 am 2

screen shot 2018-06-24 at 8 10 17 am 2

@jamesmillerburgess jamesmillerburgess force-pushed the jamesmillerburgess:bundle-visualizer-pillboxes branch from 91814f5 to 427fcff Jun 24, 2018

@jamesmillerburgess

This comment has been minimized.

Contributor

jamesmillerburgess commented Jun 26, 2018

From the emoji poll it looks like there aren't any objections here, so I'm going to remove the WIP tag and this should be ready for review. 👍

@jamesmillerburgess jamesmillerburgess changed the title from [WIP] Split bundles into separate sunbursts in bundle-visualizer to Split bundles into separate sunbursts in bundle-visualizer Jun 26, 2018

@benjamn benjamn merged commit 9b0f38c into meteor:devel Jun 29, 2018

18 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Clean Up Your tests passed on CircleCI!
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 10 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jamesmillerburgess jamesmillerburgess deleted the jamesmillerburgess:bundle-visualizer-pillboxes branch Jun 29, 2018

@benjamn

This comment has been minimized.

Member

benjamn commented Jun 29, 2018

This has been published (just now) as bundle-visualizer@1.2.2. Tested in multiple browsers, with both one and two bundles. Great work @jamesmillerburgess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment