New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resolving index.* modules with non-.js file extensions. #10027

Merged
merged 2 commits into from Jun 25, 2018

Conversation

Projects
None yet
2 participants
@benjamn
Member

benjamn commented Jun 25, 2018

As reported by @justinanastos via Slack, files with non-.js file extensions (e.g. index.tsx) cannot be used to make a directory importable in the same way that an index.js module can.

Fixing this involves updating both the runtime module system and our build-time Resolver logic (this PR).

Unfortunately this fix will have to wait for the next Meteor release, since it involves changes to the build tool.

Allow resolving index.* modules with non-.js file extensions.
The previous commit enabled importing index.* modules at runtime, but
unfortunately the build-time Resolver logic also needed updating, which
will require a new Meteor release.

@benjamn benjamn added this to the Release 1.7.1 milestone Jun 25, 2018

@benjamn benjamn self-assigned this Jun 25, 2018

@benjamn benjamn requested review from hwillson and abernix Jun 25, 2018

@benjamn benjamn merged commit 9f06a6f into devel Jun 25, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CLA Author has signed the Meteor CLA.
Details
@hwillson

Sorry I was late to the party on this one @benjamn - this and 445fd37 look great and make sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment