New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.0.4 #10134

Merged
merged 15 commits into from Aug 7, 2018

Conversation

Projects
None yet
4 participants
@benjamn
Member

benjamn commented Aug 6, 2018

Quick patch release to address @babel/runtime issues such as #10126, introduced by the removal of the @babel/runtime/helpers/builtin directory in babel/babel#8266 (which, to be clear, is a valuable change in the long term, even though it's somewhat annoying in the short term).

Plan:

  • Make the Meteor babel-runtime@1.2.3 package complain if you install @babel/runtime@7.0.0-beta.56 or higher in your application's node_modules directory.
  • Make sure new Meteor 1.7.0.4 apps install @babel/runtime@7.0.0-beta.55 and nothing later.
  • Publish Meteor 1.7.0.4 as a patch release, so that everyone using Meteor 1.7.0.x sees an update banner.
  • Bump the minor version of babel-runtime (to 1.3.0) on the release-1.7.1 branch, and undo the changes above.

benjamn added some commits Aug 6, 2018

@benjamn benjamn added this to the Release 1.7.0.4 milestone Aug 6, 2018

@benjamn benjamn self-assigned this Aug 6, 2018

@benjamn benjamn requested review from hwillson and abernix Aug 6, 2018

benjamn added some commits Aug 6, 2018

Pin test app @babel/... dependencies to version 7.0.0-beta.55.
Also updated the dynamic-import test app to Meteor 1.7.0.3.
Update npm to version 6.3.0 and pacote to version 8.1.6.
Cherry-picking this change from the release-1.7.1 branch, where it has
been well-validated by our beta testers.

Fixes #9940.
@hwillson

Looks great @benjamn - thanks!

@abernix

abernix approved these changes Aug 7, 2018

LGTM! (One comment below, but I'm just talking to myself out loud.)

@@ -1 +1 @@
METEOR@1.6.1
METEOR@1.7.0.3

This comment has been minimized.

@abernix

abernix Aug 7, 2018

Member

If I recall, this (as in the dynamic-import test app's Meteor version) is intentionally held back until the version is officially released, correct?

That is to say, this is intentionally not 1.7.0.4 yet.

This comment has been minimized.

@benjamn

benjamn Aug 7, 2018

Member

That's right. I will update it again once the final release commit is merged into devel.

j18ter and others added some commits Jul 18, 2018

Request less than 4GB on 32-bit platforms (#10081)
A recent commit added a flag to request 4GB space for node, which
causes an immediate segmentation fault on 32-bit Linux.

@benjamn benjamn merged commit f033e49 into master Aug 7, 2018

20 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci: Clean Up Your tests passed on CircleCI!
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 10 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

benjamn added a commit that referenced this pull request Aug 7, 2018

benjamn added a commit that referenced this pull request Aug 7, 2018

Adjust @babel/runtime version constraints in test app package.json fi…
…les.

According to the plan described in #10134, whereas we had to pin these
versions to exactly 7.0.0-beta.55 for Meteor 1.7.0.4, we must now require
at least 7.0.0-beta.56 for Meteor 1.7.1, since other @babel/... packages
used by babel-compiler and meteor-babel are currently at beta.56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment