Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make array-field sorting compatible with mongo 3.6+ behavior #10214

Merged
merged 2 commits into from Sep 11, 2018

Conversation

@sebakerckhof
Copy link
Contributor

@sebakerckhof sebakerckhof commented Sep 11, 2018

Fixes #10212 . Note that while it is now compatible with Mongo 3.6+, it's incompatible with mongo < 3.6

@benjamn benjamn merged commit b8cbe5a into meteor:devel Sep 11, 2018
17 of 18 checks passed
17 of 18 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Clean Up Your tests passed on CircleCI!
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 10 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@filipenevola
Copy link
Member

@filipenevola filipenevola commented Sep 11, 2018

Should we add this change to the new Breaking changes section on History?

@mitar
Copy link
Collaborator

@mitar mitar commented Sep 11, 2018

Oho, that was a quick fix. Thanks!

@sebakerckhof
Copy link
Contributor Author

@sebakerckhof sebakerckhof commented Sep 11, 2018

Oho, that was a quick fix. Thanks!

The most fun PR's are just removing a bunch of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.