Skip to content

Make array-field sorting compatible with mongo 3.6+ behavior #10214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2018
Merged

Make array-field sorting compatible with mongo 3.6+ behavior #10214

merged 2 commits into from
Sep 11, 2018

Conversation

sebakerckhof
Copy link
Contributor

@sebakerckhof sebakerckhof commented Sep 11, 2018 •
edited
Loading

Fixes #10212 . Note that while it is now compatible with Mongo 3.6+, it's incompatible with mongo < 3.6

@benjamn benjamn merged commit b8cbe5a into meteor:devel Sep 11, 2018
@filipenevola
Copy link
Contributor

Should we add this change to the new Breaking changes section on History?

@mitar
Copy link
Contributor

mitar commented Sep 11, 2018

Oho, that was a quick fix. Thanks!

@sebakerckhof
Copy link
Contributor Author

Oho, that was a quick fix. Thanks!

The most fun PR's are just removing a bunch of code.

@sebakerckhof sebakerckhof mentioned this pull request Sep 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebakerckhof @filipenevola @mitar @benjamn