Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova improvements for Meteor 1.8.1 #10339

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
7 participants
@benjamn
Copy link
Member

commented Nov 15, 2018

Incomplete list of key improvements:

@benjamn benjamn added this to the Release 1.8.1 milestone Nov 15, 2018

@benjamn benjamn self-assigned this Nov 15, 2018

@benjamn benjamn requested review from hwillson and abernix Nov 15, 2018

@benjamn benjamn changed the base branch from release-1.8.1 to devel Nov 15, 2018

@benjamn benjamn changed the base branch from devel to release-1.8.1 Nov 15, 2018

@benjamn benjamn changed the title Cordova improvements for Meteor 1.8.1 [WIP] Cordova improvements for Meteor 1.8.1 Nov 15, 2018

@jastakhova

This comment has been minimized.

Copy link

commented Nov 26, 2018

Hi, @benjamn !
Can you suggest how to include the flag "-UseModernBuildSystem=0" to meteor run for ios while this fix is getting released? I am trying to make "meteor run ios" work with the emulator.

@dagatsoin

This comment has been minimized.

Copy link

commented Nov 30, 2018

Maybe this could be added too: #10308
It makes impossible to use some plugin, because the generated build.gradle seems to generated a deprecated repository order.

@dagatsoin

This comment has been minimized.

Copy link

commented Dec 10, 2018

Made a PR for the repositories order problem. meteor/cordova-android#1

@macrozone

This comment has been minimized.

Copy link

commented Dec 13, 2018

please also include meteor/cordova-plugin-meteor-webapp#66

@derouck

This comment has been minimized.

Copy link

commented Dec 14, 2018

If you're stuck with Xcode 10 issues, the easiest way is probably to downgrade Xcode for now...

https://medium.com/@tseboho/how-to-downgrade-xcode-4359df5158d5

@tromgy

This comment has been minimized.

Copy link

commented Dec 15, 2018

@jastakhova This is how I made meteor run ios work with XCode 10:

add this line

options.push('--buildFlag=-UseModernBuildSystem=0');

right after

run(platform, isDevice, options = [], extraPaths = []) {
    return Promise.asyncApply(() => {
      options.push(isDevice ? '--device' : '--emulator');

in ~/.meteor/packages/meteor-tool/1.8.0_1/mt-os.osx.x86_64/tools/cordova/project.js

@drone1

This comment has been minimized.

Copy link

commented Dec 23, 2018

options.push('--buildFlag=-UseModernBuildSystem=0');

@tromgy Bless your heart, this worked for me w/ Xcode 10.1 (10B61), Meteor 1.8.0.1.

benjamn added some commits Nov 15, 2018

@benjamn benjamn force-pushed the cordova-improvements-for-meteor-1.8.1 branch from fae3c73 to 6e262d4 Jan 11, 2019

@benjamn benjamn changed the title [WIP] Cordova improvements for Meteor 1.8.1 Cordova improvements for Meteor 1.8.1 Jan 11, 2019

@benjamn benjamn merged commit 178a4be into release-1.8.1 Jan 11, 2019

17 of 19 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Clean Up Your tests passed on CircleCI!
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 10 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 5 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@benjamn benjamn deleted the cordova-improvements-for-meteor-1.8.1 branch Jan 11, 2019

benjamn added a commit that referenced this pull request Jan 11, 2019

@benjamn benjamn referenced this pull request Jan 11, 2019

Merged

Release 1.8.1 #10248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.