New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multiple restart feature #10345
Remove multiple restart feature #10345
Conversation
var runResult = self._runOnce({ | ||
onListen: function () { | ||
if (! self.noRestartBanner && ! firstRun) { | ||
runLog.logRestart(); | ||
Console.enableProgressDisplay(false); | ||
} | ||
}, | ||
beforeRun: resetCrashCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the beforeRun
option be removed from AppRunner
? It's only used here.
This change uncovered a bug in the You can reproduce this with a Meteor app that accesses the database immediately after it started: import { Meteor } from "meteor/meteor";
import { Mongo } from "meteor/mongo";
const Collection = new Mongo.Collection("collection");
Meteor.startup(() => {
Collection.findOne();
}); First, run the app with |
47dc3d5
to
a027fcc
Compare
The failing test in Test Group 8 (mongo with multiple --port numbers) will pass when 2b21a90 is merged into |
93d4f01
to
0b8b1f5
Compare
This comment has been minimized.
This comment has been minimized.
0b8b1f5
to
a922990
Compare
Removes the logic that restarts a crashing Meteor server twice if there is a runtime error.
Fixes meteor/meteor-feature-requests#335.