Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop excluding test modules when meteor.testModule found in package.json. #10402

Merged
merged 1 commit into from Jan 6, 2019

Conversation

@benjamn
Copy link
Member

@benjamn benjamn commented Jan 6, 2019

New Meteor apps have the following meteor.testModule in their package.json files by default:

"meteor": {
  "testModule": "tests/main.js"
}

When meteor.testModule is defined, it determines the test entry point when running the meteor test command, ignoring legacy file naming conventions like *.tests.js or *.app-tests.js.

The package-source.js code changed by this commit was incorrect because it ignored those specially-named test files even when running tests, which was a problem if the meteor.testModule tried to import them explicitly, because they would not be properly compiled.

If you're using meteor.testModule, the distinction between meteor test and meteor test --full-app matters a bit less, since the test entry point will be the same for both modes, though you can still check Meteor.isTest and Meteor.isAppTest at runtime to control test behavior.

@benjamn benjamn added this to the Docs, Guide, Tutorials milestone Jan 6, 2019
@benjamn benjamn self-assigned this Jan 6, 2019
@benjamn benjamn force-pushed the fix-imported-test-files-for-tutorial branch from a50adb4 to 183c1e3 Jan 6, 2019
…son.

New Meteor apps have the following meteor.testModule in their package.json
files by default

  "meteor": {
    "testModule": "tests/main.js"
  }

When meteor.testModule is defined, it determines the test entry point when
running the `meteor test` command, ignoring legacy file naming conventions
like *.tests.js or *.app-tests.js.

The package-source.js code changed by this commit was incorrect because it
ignored those specially-named test files even when running tests, which
was a problem if the meteor.testModule tried to import them explicitly,
because they would not be properly compiled.

If you're using meteor.testModule, the distinction between `meteor test`
and `meteor test --full-app` matters a bit less, since the test entry
point will be the same for both modes, though you can still check
Meteor.isTest and Meteor.isAppTest at runtime to control test behavior.
@benjamn benjamn force-pushed the fix-imported-test-files-for-tutorial branch from 183c1e3 to deb5677 Jan 6, 2019
@benjamn benjamn merged commit fb2146c into devel Jan 6, 2019
1 of 6 checks passed
@benjamn benjamn deleted the fix-imported-test-files-for-tutorial branch Jan 6, 2019
benjamn added a commit that referenced this issue Jan 6, 2019
…son. (#10402)

New Meteor apps have the following meteor.testModule in their package.json
files by default

  "meteor": {
    "testModule": "tests/main.js"
  }

When meteor.testModule is defined, it determines the test entry point when
running the `meteor test` command, ignoring legacy file naming conventions
like *.tests.js or *.app-tests.js.

The package-source.js code changed by this commit was incorrect because it
ignored those specially-named test files even when running tests, which
was a problem if the meteor.testModule tried to import them explicitly,
because they would not be properly compiled.

If you're using meteor.testModule, the distinction between `meteor test`
and `meteor test --full-app` matters a bit less, since the test entry
point will be the same for both modes, though you can still check
Meteor.isTest and Meteor.isAppTest at runtime to control test behavior.
@benjamn benjamn mentioned this pull request Jan 6, 2019
benjamn added a commit that referenced this issue Mar 19, 2019
@benjamn benjamn removed this from the Docs, Guide, Tutorials milestone Mar 19, 2019
@benjamn benjamn added this to the Release 1.8.1 milestone Mar 19, 2019
@benjamn benjamn removed this from the Release 1.8.1 milestone Mar 19, 2019
@benjamn benjamn added this to the Release 1.8.0.2 milestone Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant