New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linker performance #10453
Linker performance #10453
Conversation
zodern
commented
Feb 14, 2019
- Updates source-map to 0.5.7 which includes some performance improvements for source nodes. In one app it saves up to 1.2 seconds during full rebuilds
- Caches the stringified output of dynamic files instead of a source node, which allows skipping stringifying the source node when the dynamic file didn't change since the last build.
- The main client bundle is not recreated when only dynamic files change. In one app this saves 2 - 3 seconds during rebuilds when a dynamic file is changed. It only stores the latest bundle in the cache for each architecture instead of waiting until the cache has reached its max size to remove old entries. That is to avoid increasing the tool's memory usage, though I am not sure if it is needed.
On a related note. It then never really was looked into further, but maybe @zodern feels like it 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few small suggestions.
@@ -34,7 +34,7 @@ var packageJson = { | |||
fstream: "https://github.com/meteor/fstream/tarball/cf4ea6c175355cec7bee38311e170d08c4078a5d", | |||
tar: "2.2.1", | |||
kexec: "3.0.0", | |||
"source-map": "0.5.3", | |||
"source-map": "0.5.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: this will require a new dev bundle.
1ef095c
to
bf3a50f
Compare
3395bdb
to
986e0a3
Compare
bf3a50f
to
bb564dd
Compare