Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in minimongo fields projection #10499

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Fix bug in minimongo fields projection #10499

merged 2 commits into from
Oct 31, 2020

Conversation

maxnowack
Copy link
Contributor

@maxnowack maxnowack commented Mar 19, 2019 •
edited
Loading

This fixes a null reference exception, if an array contains null values while compiling a fields projection.

maxnowack added 2 commits July 23, 2019 16:45
@maxnowack
Fix bug in minimongo fields projection
2b024b2 
This fixes a null reference exception while compiling a fields projection, if an array contains a null value
@maxnowack
Extend tests
ca39937
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sebakerckhof sebakerckhof self-requested a review January 23, 2020 16:14
StorytellerCZ
StorytellerCZ approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer if there was a dedicated test for it rather than using existing, but it will do.

@filipenevola filipenevola added this to the Release 1.12 milestone Oct 28, 2020
@filipenevola filipenevola changed the base branch from devel to release-1.12 October 31, 2020 15:34
@filipenevola filipenevola merged commit a3a5a39 into meteor:release-1.12 Oct 31, 2020
@filipenevola filipenevola added the confirmed We want to fix or implement it label Oct 31, 2020
@maxnowack maxnowack deleted the patch-1 branch November 1, 2020 17:12
@filipenevola filipenevola mentioned this pull request Nov 10, 2020
Closed
@mitar mitar mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StorytellerCZ StorytellerCZ StorytellerCZ approved these changes

@sebakerckhof sebakerckhof Awaiting requested review from sebakerckhof

Assignees
No one assigned
Labels
confirmed We want to fix or implement it Project:Minimongo
Projects
None yet
Milestone
Release 1.12
Development

Successfully merging this pull request may close these issues.
4 participants
@maxnowack @CLAassistant @StorytellerCZ @filipenevola