Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until primary node is writable #10500

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@klaussner
Copy link
Contributor

@klaussner klaussner commented Mar 19, 2019

Using the isMaster command instead of checking the replica set member state is more reliable because a node can be a primary without being writable (see #10381 (comment) for details).

Fixes #10381 (and #9026).

Using the `isMaster` command instead of checking the replica set member state is more reliable because a node can be a primary without being writable.
continue;
}
const { ismaster } = yieldingMethod(db.admin(), "command", {
isMaster: 1
Copy link
Member

@benjamn benjamn Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case anyone is wondering, the isMaster command has been supported since well before Mongo 3.2.22, which is the version we use for 32-bit systems: https://docs.mongodb.com/v2.2/reference/command/isMaster/

@benjamn benjamn added this to the Release 1.8.1 milestone Mar 19, 2019
@benjamn
Copy link
Member

@benjamn benjamn commented Mar 19, 2019

This definitely counts as a bug fix, and therefore qualifies for Meteor 1.8.1, even though we just entered the release candidate phase.

Copy link
Member

@benjamn benjamn left a comment

Assuming tests pass, I would just request a note in History.md about this change (or let me know if you don't have time for that). Thanks for following up on this long-standing bug!

@benjamn benjamn changed the base branch from devel to release-1.8.1 Mar 19, 2019
@benjamn benjamn merged commit 2b21a90 into meteor:release-1.8.1 Mar 19, 2019
15 of 17 checks passed
klaussner added a commit to klaussner/meteor that referenced this issue Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants