Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until primary node is writable #10500

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@klaussner
Copy link
Collaborator

commented Mar 19, 2019

Using the isMaster command instead of checking the replica set member state is more reliable because a node can be a primary without being writable (see #10381 (comment) for details).

Fixes #10381 (and #9026).

Wait until primary node is writable
Using the `isMaster` command instead of checking the replica set member state is more reliable because a node can be a primary without being writable.
continue;
}
const { ismaster } = yieldingMethod(db.admin(), "command", {
isMaster: 1

This comment has been minimized.

Copy link
@benjamn

benjamn Mar 19, 2019

Member

In case anyone is wondering, the isMaster command has been supported since well before Mongo 3.2.22, which is the version we use for 32-bit systems: https://docs.mongodb.com/v2.2/reference/command/isMaster/

@benjamn benjamn added this to the Release 1.8.1 milestone Mar 19, 2019

@benjamn

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

This definitely counts as a bug fix, and therefore qualifies for Meteor 1.8.1, even though we just entered the release candidate phase.

@benjamn
Copy link
Member

left a comment

Assuming tests pass, I would just request a note in History.md about this change (or let me know if you don't have time for that). Thanks for following up on this long-standing bug!

@benjamn benjamn changed the base branch from devel to release-1.8.1 Mar 19, 2019

@benjamn benjamn merged commit 2b21a90 into meteor:release-1.8.1 Mar 19, 2019

15 of 17 checks passed

ci/circleci: Test Group 10 Your tests failed on CircleCI
Details
ci/circleci: Test Group 5 Your tests failed on CircleCI
Details
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details
ci/circleci: Get Ready Your tests passed on CircleCI!
Details
ci/circleci: Isolated Tests Your tests passed on CircleCI!
Details
ci/circleci: Test Group 0 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 1 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 2 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 3 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 4 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 6 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 7 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 8 Your tests passed on CircleCI!
Details
ci/circleci: Test Group 9 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

klaussner added a commit to klaussner/meteor that referenced this pull request Mar 20, 2019

benjamn added a commit that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.