Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dev-bundle.js to TypeScript #10662

Open
wants to merge 5 commits into
base: release-1.8.2
from

Conversation

@jamesmillerburgess
Copy link
Contributor

commented Aug 3, 2019

I did this before reading the comment at the top of the file 馃槄 :

// Note that this file is required before we install our Babel hooks in
// ../tool-env/install-babel.js, so we can't use ES2015+ syntax here.

As well, the tests don't run, so guess the TypeScript compiler is also not running here?

So I'm not sure if we should even be converting this, but I'm making a PR since I already did it.

There is one use of the any type: the data parameter in the sqlite3 callback. This is the same type as in @types/sqlite3:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/bb36642c70f366af454e1bf67471fbfdf0b9bdc8/types/sqlite3/index.d.ts#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.