-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update MongoDB to 4.2 #10723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MongoDB to 4.2 #10723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started. Those to-dos are going to be the hard part, I suspect.
Just curious why meteor did not go the docker route for mongodb? More work for devs? |
7f82eff
to
ee9c7b1
Compare
I've updated all URLs to the latest versions. For now, the custom Linux build is downloaded from the GitHub releases of my |
ee9c7b1
to
d7aa66f
Compare
Regarding the custom MongoDB build: Should I transfer the |
Sure @klaussner , go ahead and transfer the repo to Meteor org, I'll provide write access to you also! |
|
ffe172a
to
87f5675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebuilt the dev bundle with Mongo 4.2, and I will merge these changes into release-1.9
assuming the tests pass. Thanks for doing all the real work @klaussner!
documentation: null | ||
}); | ||
|
||
Npm.depends({ | ||
mongodb: "3.2.7" | ||
mongodb: "3.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I took the liberty of updating the mongodb
npm package to the latest version (@klaussner had used 3.3.2 in the original version of this PR). Maybe that was not a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea 😉 I believe @klaussner was going to do the same.
I haven't figured out yet why the "mongo with multiple --port numbers" test doesn't pass. MongoDB outputs file locking errors when the port is changed. 🤔
|
0ee6c5b
to
6843b25
Compare
I found out what the problem was. The test runs Meteor multiple times in a row but I also removed the |
packages/npm-mongo/package.js
Outdated
@@ -3,12 +3,12 @@ | |||
|
|||
Package.describe({ | |||
summary: "Wrapper around the mongo npm package", | |||
version: "3.3.0-rc190.0", | |||
version: "3.4.0-rc190.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right version number?
The Travis CI build fails because the custom |
I changed the build script to link |
To do: