Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facebook API calls to v5 #10738

Merged
merged 5 commits into from Feb 12, 2020
Merged

Conversation

StorytellerCZ
Copy link
Contributor

@StorytellerCZ StorytellerCZ commented Oct 14, 2019

Updates Facebook API endpoints to v4. There are no changes in this regards since v3 upgrade. As far as I have tested everything went smoothly.

@filipenevola
Copy link
Member

@filipenevola filipenevola commented Nov 19, 2019

@StorytellerCZ v4 is 100% compatible with v3? Could you update your branch as 1.8.2 was already release? Thanks

@StorytellerCZ
Copy link
Contributor Author

@StorytellerCZ StorytellerCZ commented Nov 19, 2019

Updated.
As for compatibility, non of the changes affect us (OAuth). V4 changes are mainly in other areas (unless I missed something). The only concern I see is in token depracation, but any concerned parties would have been notified by Facebook already.

Since I created this PR, v5 of the API has been released. Also in this case the breaking changes are not in OAuth so it is safe to upgrade.

@sebakerckhof sebakerckhof self-requested a review Jan 23, 2020
@sebakerckhof
Copy link
Contributor

@sebakerckhof sebakerckhof commented Jan 23, 2020

@StorytellerCZ Could you maybe update this to v5?

@StorytellerCZ StorytellerCZ changed the title Update Facebook API calls to v4 Update Facebook API calls to v5 Jan 26, 2020
@StorytellerCZ
Copy link
Contributor Author

@StorytellerCZ StorytellerCZ commented Jan 26, 2020

@sebakerckhof Done!

@filipenevola filipenevola added this to the Release 1.10 milestone Jan 31, 2020
@filipenevola filipenevola merged commit 925d6e1 into meteor:devel Feb 12, 2020
18 checks passed
@StorytellerCZ StorytellerCZ deleted the facebook-api-update branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants