Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrader to add jquery dependency for blaze-users #10801

Merged

Conversation

@sebakerckhof
Copy link
Contributor

sebakerckhof commented Nov 26, 2019

While jquery is now a theoretical weak dependency of blaze, in reality everyone uses the jquery dombackend of blaze. So try to limit the complaints about apps being broken. (they will still need to have it as an NPM dependency, but at least the jquery package gives a clear error message if this isn't the case)

@benjamn benjamn added this to the Release 1.8.3 milestone Nov 26, 2019
@benjamn

This comment has been minimized.

Copy link
Member

benjamn commented Nov 26, 2019

Good thinking!

@mitar @filipenevola I think we might need to release new versions of the Blaze packages to get the test failures in #10498 (and here) to pass. The necessary changes have been pushed to blaze/master but not published to the package server. Let me know if you don't have time right now, or if you have any questions.

@mitar

This comment has been minimized.

Copy link
Collaborator

mitar commented Nov 26, 2019

I do not have time right now to look into this, sorry.

@benjamn benjamn force-pushed the meteor:avoid-bundling-jquery-twice branch from 3cc3b9c to 73d82d7 Dec 18, 2019
@benjamn benjamn changed the base branch from avoid-bundling-jquery-twice to release-1.8.3 Dec 18, 2019
@benjamn benjamn force-pushed the sebakerckhof:chore/add-blaze-jquery-upgrader branch from 9a9bf71 to 8ec8cc1 Dec 18, 2019
@benjamn benjamn merged commit 8316c40 into meteor:release-1.8.3 Dec 18, 2019
1 of 5 checks passed
1 of 5 checks passed
ci/circleci: Docs CircleCI is running your tests
Details
ci/circleci: Get Ready CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
benjamn added a commit that referenced this pull request Dec 18, 2019
benjamn added a commit that referenced this pull request Dec 18, 2019
@benjamn benjamn modified the milestones: Release 1.8.4, Release 1.8.3 Dec 18, 2019
@benjamn benjamn mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.