Add upgrader to add jquery dependency for blaze-users #10801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good thinking! @mitar @filipenevola I think we might need to release new versions of the Blaze packages to get the test failures in #10498 (and here) to pass. The necessary changes have been pushed to |
|
I do not have time right now to look into this, sorry. |
benjamn
force-pushed
the
avoid-bundling-jquery-twice
branch
from
3cc3b9c
to
73d82d7
Compare
benjamn
changed the base branch from
avoid-bundling-jquery-twice
to
release-1.8.3
benjamn
force-pushed
the
chore/add-blaze-jquery-upgrader
branch
from
9a9bf71
to
8ec8cc1
Compare
benjamn
approved these changes
Dec 18, 2019
benjamn
pushed a commit
that referenced
this pull request
Dec 18, 2019
benjamn
pushed a commit
that referenced
this pull request
Dec 18, 2019
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While jquery is now a theoretical weak dependency of blaze, in reality everyone uses the jquery dombackend of blaze. So try to limit the complaints about apps being broken. (they will still need to have it as an NPM dependency, but at least the
jquerypackage gives a clear error message if this isn't the case)