Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error when removing cordova plugin that depends on cli variables #11052

Merged

Conversation

filipenevola
Copy link
Member

@filipenevola filipenevola commented May 10, 2020

When we have plugins that use variables and Meteor integration tries to remove them it was not passing the variables and then the remove was failing.

In this PR I've changed the plugins remove command to remove the plugins one by one extracting the cli_variables for the plugin being removed currently.

For example, cordova-plugin-facebook4 needs APP_ID and the removal was always failing because Meteor integration was not providing this variable.

@filipenevola filipenevola added this to the Release 1.10.3 milestone May 10, 2020
@filipenevola filipenevola changed the base branch from devel to release-1.10.3 May 10, 2020
@filipenevola filipenevola merged commit e2d3fd6 into release-1.10.3 May 11, 2020
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants