Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create command for vuejs #11086

Merged
merged 2 commits into from Jun 8, 2020
Merged

Add create command for vuejs #11086

merged 2 commits into from Jun 8, 2020

Conversation

chris-visser
Copy link
Contributor

@chris-visser chris-visser commented Jun 7, 2020

This PR provides first class Vue integration into Meteor using the create command.

filipenevola and others added 2 commits Jun 3, 2020
- Tree shaking update
- Cordova example update
- Windows performance update
- Angular tutorial fix (it is not updated yet)
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2020

CLA assistant check
All committers have signed the CLA.

mullojo
mullojo approved these changes Jun 7, 2020
Copy link
Contributor

@mullojo mullojo left a comment

Looks great @chris-visser !

@aogaili
Copy link

aogaili commented Jun 8, 2020

Great work, I'm going to give Vue a try!

@filipenevola filipenevola added this to the Release 1.10.3 milestone Jun 8, 2020
@filipenevola filipenevola changed the base branch from devel to release-1.10.3 Jun 8, 2020
@filipenevola filipenevola reopened this Jun 8, 2020
@filipenevola
Copy link
Member

filipenevola commented Jun 8, 2020

Thanks, great work, this would be available on Meteor 1.10.3

@filipenevola filipenevola merged commit 239bae9 into meteor:release-1.10.3 Jun 8, 2020
16 of 18 checks passed
@StephaneRavet
Copy link

StephaneRavet commented Sep 2, 2020

Hi,

A problem appeared with v1.11 which introduce command "meteor create --vue".

Actual behavior : ReferenceError: window is not defined if we use window in any .vue file.

In any .vue file, if we use window.innerHeight for example, the build will report : ReferenceError: window is not defined, because only folders imports, client, public and test are excluded from server build. I think, the src folder, used by skel-vue is not appropriate.

Ok, you can tell me : use if (Meteor.isClient) { console.info(window) } to fix it.
Yes, but if we use a library that uses window, we can't write if (Meteor.isClient) { import { Editor } from '@toast-ui/vue-editor' } to fix it.

Solution found :

  • rename the src folder into imports.
  • New problem after that : main.html is not loaded. If I put it to /client/main.html, it builds without errors.

Reproduction : https://github.com/StephaneRavet/meteor-create-vue-window-bug
Solution : https://github.com/StephaneRavet/meteor-create-vue-window-bug/tree/solution

Do you agree ?

@chris-visser
Copy link
Contributor Author

chris-visser commented Sep 4, 2020

@StephaneRavet Yes. I've noticed too that there are some caveats to the current structure. I will make a PR for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants