Dynamic Imports: Dynamic Origin Option (CORS) #11105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afrokick
reviewed
Jun 28, 2020
leonardoventurini
force-pushed
the
dynamic-imports-cors
branch
from
ead3599 to
f302c96
Compare
filipenevola
requested changes
Jul 6, 2020
sebakerckhof
suggested changes
Jul 9, 2020
leonardoventurini
force-pushed
the
dynamic-imports-cors
branch
from
f302c96 to
3cc48f6
Compare
leonardoventurini
force-pushed
the
dynamic-imports-cors
branch
from
6b46c82 to
00ac165
Compare
|
@leonardoventurini is this ready to be merged? If so please remove WIP label 😉 |
Sorry I completely forgot about this, I believe it is ready but I will double-check if I have anything pending. |
filipenevola
approved these changes
Oct 2, 2020
|
This works like a charm. After 2 years, I can finally remove my |
mariogasparoni
added a commit
to mariogasparoni/meteor
that referenced
this pull request
Oct 18, 2021
When setting "useLocationOrigin: true" and also using a root url like ROOT_URL=http://host:port/mypath , dynamic-import will ignore "mypath" when fetching for files to be imported, resulting in a 404 for these files. To bypass this problem, i changed the code to prepend the "mypath" to the module's URL, before trying to fetch it. Related to meteor#11105.
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option for
dynamic-importsto fetch from the current origin instead of the absolute URL.